search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 265 forks source link

[Link Event Damping] Port state change handler class #1310

Closed Ashish1805 closed 10 months ago

Ashish1805 commented 11 months ago

Class to handle the port state change event callback from SAI and sending the link events to syncd main thread for processing by link event damper.

HLD: sonic-net/SONiC#1071

kcudnik commented 11 months ago

could you give more meaningful title and description ?

Ashish1805 commented 10 months ago

could you give more meaningful title and description ?

Changed the title and description. Thank you.

Ashish1805 commented 10 months ago

Adding @Junchao-Mellanox for review.

Ashish1805 commented 10 months ago

Hi @kcudnik , I dont have permission to merge PRs. Can you please merge this PR? Thank you.

kcudnik commented 10 months ago

is this ready to merge ?

Ashish1805 commented 10 months ago

is this ready to merge ?

Yes, it is ready for merge. Thanks.

kcudnik commented 10 months ago

@Ashish1805 your change caused compilation issues on swss, please fix this right away or this change will be reverted: https://github.com/sonic-net/sonic-swss/actions/runs/6910957833/job/18804862990?pr=2902

kcudnik commented 10 months ago

change 

static constexpr size_t PortStateChangeHandler::PORT_STATE_CHANGE_QUEUE_SIZE;

to

constexpr size_t PortStateChangeHandler::PORT_STATE_CHANGE_QUEUE_SIZE;

first keyword static requires declaration in cpp file since it's considered a field