Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference.

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project

Other

56 stars 263 forks source link

Fix compilation issue due to PORT_STATE_CHANGE_QUEUE_SIZE undefined reference. #1324

Closed Ashish1805 closed 9 months ago

Ashish1805 commented 9 months ago

In PR https://github.com/sonic-net/sonic-sairedis/pull/1310, a constexpt static data member was added. Since sairedis repo uses c++14, definition of this data member needs to be provided in .cpp file too.

Ashish1805 commented 9 months ago

@kcudnik I think there is some issue in CodeQL / Analyze (cpp) (pull_request_target) check. It doesn't seem to include the current PR when running the check - rather it runs the check on the head of master that was base for this current PR. This will also explain why check didn't fail for PR https://github.com/sonic-net/sonic-sairedis/pull/1310 before merge.

prsunny commented 9 months ago

@kcudnik , we may want to force-merge this.