sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 263 forks source link

Add libsai RedisInterface for link event damping. #1331

Open Ashish1805 opened 9 months ago

Ashish1805 commented 9 months ago

HLD: sonic-net/SONiC#1071

Ashish1805 commented 9 months ago

@Junchao-Mellanox for review.

Ashish1805 commented 9 months ago

@kcudnik looks like swss pytest is failing - it seems unrelated to my changes. Any idea how to fix the swss pytest?

kcudnik commented 9 months ago

those vstests are sometime flaky so dont worry about that

Ashish1805 commented 9 months ago

@kcudnik I have updated the PR as per review comment. can you please review it when you get a chance? Thank you.

kcudnik commented 7 months ago

please fix build erros and code coverage

Ashish1805 commented 4 months ago

@kcudnik Added the code coverage but I see PR is failing for 2 tests during Update rsyslog.conf test. The test failure log doesn't give much info, can you suggest where can I find the helpful debug log to figure out what exactly failed and why?

kcudnik commented 4 months ago

@kcudnik Added the code coverage but I see PR is failing for 2 tests during Update rsyslog.conf test. The test failure log doesn't give much info, can you suggest where can I find the helpful debug log to figure out what exactly failed and why?

rsyslogd: pidfile '/run/rsyslogd.pid' and pid 18837 already exist.
If you want to run multiple instances of rsyslog, you need to specify

in ~/sonic-sairedis/.azure-pipelines/build-template.yml

68   - script: |
169       sudo cp azsyslog.conf /etc/rsyslog.conf
170       sudo service rsyslog restart
171     displayName: "Update rsyslog.conf"

seems like syslog service restart failed but why, no clue, we would need to look into syslog on pipeline but i dont know how :D maybe update buitld template to do "tail -n 100 /var/log/syslog ? after restaret command ?

Ashish1805 commented 3 months ago

/AzurePipelines run

azure-pipelines[bot] commented 3 months ago
Commenter does not have sufficient privileges for PR 1331 in repo sonic-net/sonic-sairedis
kcudnik commented 3 months ago

/azp run

azure-pipelines[bot] commented 3 months ago
Azure Pipelines successfully started running 1 pipeline(s).