search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 263 forks source link

Support ASIC/SDK health event #1340

Closed stephenxs closed 4 months ago

stephenxs commented 7 months ago

Support ASIC/SDK health event

  1. Handle vendor SAI ASIC/SDK health event and encode it
  2. Pass it to swss through the communication channel.
kcudnik commented 7 months ago

a first glance this looks good, i will do a full review after you will move that out of draft

stephenxs commented 5 months ago

/azpw run

mssonicbld commented 5 months ago

/AzurePipelines run

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
stephenxs commented 5 months ago

Failure is not relevant to the PR. Retried.

test_sub_port_intf_nhg_accel failed (1 runs remaining out of 2).
    <class 'AssertionError'>
    Unexpected number of keys: expected=6, received=4 (('oid:0x2d00000000084a', 'oid:0x2d00000000084d', 'oid:0x2d00000000084c', 'oid:0x2d00000000084b')), table="ASIC_STATE:SAI_OBJECT_TYPE_NEXT_HOP_GROUP_MEMBER"
    [<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1474>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1410>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/dvslib/dvs_database.py:402>]
test_sub_port_intf_nhg_accel failed; it passed 0 out of the required 1 times.
    <class 'AssertionError'>
    Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
    [<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1463>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed (1 runs remaining out of 2).
    <class 'AssertionError'>
    Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
    [<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_sub_port_intf_oper_down_with_pending_neigh_route_tasks failed; it passed 0 out of the required 1 times.
    <class 'AssertionError'>
    Wrong # of default vrfs: 2, expected #: 1.
assert 2 == 1
  -2
  +1
    [<TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:1603>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:86>, <TracebackEntry /agent/_work/1/s/sonic-swss/tests/test_sub_port_intf.py:393>]
test_nonflaky_dummy passed 1 out of the required 1 times. Success!
stephenxs commented 5 months ago

/azpw run

mssonicbld commented 5 months ago

/AzurePipelines run

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
stephenxs commented 4 months ago

@kcudnik @prsunny Could you help to merge this PR? Thanks

liat-grozovik commented 4 months ago

@kcudnik could you please help to merge?

prsunny commented 4 months ago

Thanks @saiarcot895 for merging. @kcudnik fyi - needed to unblock an swss log issue.

kcudnik commented 4 months ago

Do you need my help ?

prsunny commented 4 months ago

Do you need my help ?

no, we are good