search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 263 forks source link

[action] [PR:1341] Revert "add if statement for module control mode support" (#1341) #1346

Closed mssonicbld closed 7 months ago

mssonicbld commented 7 months ago

Reverts #1305

this logic is not needed. we'll change sai.profile directly

mssonicbld commented 7 months ago

Original PR: https://github.com/sonic-net/sonic-sairedis/pull/1341

mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
dbarashinvd commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Commenter does not have sufficient privileges for PR 1346 in repo sonic-net/sonic-sairedis
dbarashinvd commented 7 months ago

/azpw run

dbarashinvd commented 7 months ago

/azpw run sonic-sairedis

liat-grozovik commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Commenter does not have sufficient privileges for PR 1346 in repo sonic-net/sonic-sairedis
kcudnik commented 7 months ago

bulild error on swss is not related to this change, i will investigate why its failinig + @qiluo-msft

dbarashinvd commented 7 months ago

/azpw run Azure.sonic-sairedis

dbarashinvd commented 7 months ago

bulild error on swss is not related to this change, i will investigate why its failinig + @qiluo-msft

hi Kamil, I replied also by email. seems like the errors already fixed. there were some other PRs failing on the same issue until yesterday night and now few are passing. can you please check why nothing happens when I try to rerun the failed checkers by commenting with /azpw ?

thanks.

kcudnik commented 7 months ago

im investigating this

mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).