search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 263 forks source link

[action] [PR:1338] Fix code coverage and ASAN not being enabled (#1338) #1348

Closed mssonicbld closed 7 months ago

mssonicbld commented 7 months ago

This fixes a breakage from #1194 where code coverage and ASAN were not enabled, due to DEB_CONFIGURE_EXTRA_FLAGS no longer being used in dh_auto_configure.

Signed-off-by: Saikrishna Arcot sarcot@microsoft.com

mssonicbld commented 7 months ago

Original PR: https://github.com/sonic-net/sonic-sairedis/pull/1338

mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
kcudnik commented 7 months ago

this change has nothing to do with swss, i think swss build is broken

mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
saiarcot895 commented 7 months ago

There's no new builds of https://dev.azure.com/mssonic/build/_build?definitionId=465&_a=summary&view=runs for some reason. That is likely causing this failure.

saiarcot895 commented 7 months ago

@xumia Looks like that pipeline got disabled because it didn't get classified. Would you be able to help with classifying that pipeline and re-enabling it? I tried to do it, but couldn't find the link to do so.

xumia commented 7 months ago

@xumia Looks like that pipeline got disabled because it didn't get classified. Would you be able to help with classifying that pipeline and re-enabling it? I tried to do it, but couldn't find the link to do so.

It is good now, right? I do nothing.

xumia commented 7 months ago

/azp run

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
kcudnik commented 7 months ago

can you add empty commit to this PR ? to see if it will trigger pipeline change ? since somehow pipeline is broken and not adding extra step instaling dash api, hence swss build error

mssonicbld commented 7 months ago

/azp run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
saiarcot895 commented 7 months ago

@xumia Looks like that pipeline got disabled because it didn't get classified. Would you be able to help with classifying that pipeline and re-enabling it? I tried to do it, but couldn't find the link to do so.

It is good now, right? I do nothing.

@xumia This is for the pipeline at https://dev.azure.com/mssonic/build/_build?definitionId=465&_a=summary (building the lib-packages target of sonic-buildimage and publishing those artifacts). It was disabled back in December because the pipeline didn't appear to be assigned to a service. To unblock this cherry-pick PR, I manually re-enabled the pipeline, triggered a build for master and 202311 branch, and then disabled the pipeline after the builds finished.

Is that pipeline now assigned to a service? If so, it can be re-enabled, I think.