search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 263 forks source link

Add new functionality to syncd_init_common.sh, to use common sai.profile #1352

Closed noaOrMlnx closed 6 months ago

noaOrMlnx commented 7 months ago

Changed config_mlnx_syncd() functionality to use common sai.profile for all SKUs, then apply the specific SKU sai.profile on top of it, and remove duplications.

Why I did it To have the ability to add common parameters to only 1 file instead of all SKUs.

noaOrMlnx commented 7 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 7 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 7 months ago
Azure Pipelines successfully started running 1 pipeline(s).
kcudnik commented 6 months ago

is this ready to merge ?

noaOrMlnx commented 6 months ago

Hi @kcudnik, Yes, the PR is ready for merge. thanks!

liat-grozovik commented 6 months ago

@noaOrMlnx please check the checkers failures. without them passing we cannot move forward and merge. 10x

noaOrMlnx commented 6 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 6 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 6 months ago
Azure Pipelines successfully started running 1 pipeline(s).
noaOrMlnx commented 6 months ago

@kcudnik checkers pass, can you please help with merging the PR?

dprital commented 6 months ago

@yxieca , Can you please cherry pick to 202311 ?

mssonicbld commented 6 months ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-sairedis/pull/1359