search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 259 forks source link

DASH SAI support for build chain of syncd #1366

Closed Pterosaur closed 4 months ago

Pterosaur commented 4 months ago

Add an option to link the dash SAI for syncd.

kcudnik commented 4 months ago

im not sure whether we should have each specific parameter for specific SAI to add expected libraries, or to add EXTRA_LIBSAI_LDFLAGS in the console before typing make, so configure should pick that up from environment set variables

Pterosaur commented 4 months ago

im not sure whether we should have each specific parameter for specific SAI to add expected libraries, or to add EXTRA_LIBSAI_LDFLAGS in the console before typing make, so configure should pick that up from environment set variables

I understand that this PR is not an elegant way to deal with the dash SAI, and it seems like a temporary fix. There are many codes in sonic-buildimage that depend on vs. It's difficult to make the vs support dual SAI or create a new sku in a short time. However, I hope we will eventually have a new SKU like virtual DPU.

kcudnik commented 4 months ago

There are no temporary fixes, it will propagate to scripts and stay forever since different versions will not be compatible in the future