Update ip commands for MACsec for Bookworm

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project

Other

56 stars 259 forks source link

Update ip commands for MACsec for Bookworm #1368

Closed saiarcot895 closed 4 months ago

saiarcot895 commented 4 months ago

Bookworm's iproute2 has built-in support for configuring MACsec with XPN ciphers. Unfortunately, the syntax is slightly different, which means changes are needed for this to work on Bookworm.

Update the iproute2 commands run for Bookworm. This does mean compatibility with Bullseye will break.

Pterosaur commented 4 months ago

https://github.com/sonic-net/sonic-sairedis/pull/1369

kcudnik commented 4 months ago

you can add tests in the same PR, you dont need extra pr just for tests

Pterosaur commented 4 months ago

you can add tests in the same PR, you dont need extra pr just for tests

Yes, but I'm not sure whether my changes will fix this coverage issue, Meanwhile, I feel I don't have the write permission for this PR. So, just raise a draft PR and ask @saiarcot895 to pick up my change.