build instruction need update to latest debian version

mgheorghe commented 5 months ago

i looked at https://github.com/sonic-net/sonic-sairedis/blob/master/README.md trying to build saiplayer the instructions are for debian8 but i see sonic is built today with newer version.

can the instructions be updated please to use a newer version of debian that sonic uses master branch.

kcudnik commented 5 months ago

those instructions dont mention specifically saiplayer, can you describe issues you are facing ?

mgheorghe commented 5 months ago

some are basic issues like changing a folder installing git so git command works, but many dependencies needed to build using those instructions fail, and even if i build it using ubuntu:trusty if i take the file i want to patch it and put it on latest sonic based on a more recent version i'm not sure it will work, this is why i was requestion the instructions to be updated to be able to build this component with a newer os that matches better the latest sonic builds.

steps/issues:

docker run --network host -it ubuntu:trusty OK
sudo apt-key adv --keyserver apt-mo.trafficmanager.net --recv-keys 417A0893 FAIL this causes further failures to install the swss .... packages
```
gpg: keyserver timed out
gpg: keyserver receive failed: keyserver error
```
echo 'deb http://apt-mo.trafficmanager.net/repos/sonic/ trusty main' | sudo tee -a /etc/apt/sources.list.d/sonic.list OK

sudo apt-get update FAIL

Err http://apt-mo.trafficmanager.net trusty/main amd64 Packages
Err http://apt-mo.trafficmanager.net trusty/main amd64 Packages
Err http://apt-mo.trafficmanager.net trusty/main amd64 Packages
Err http://apt-mo.trafficmanager.net trusty/main amd64 Packages
Err http://apt-mo.trafficmanager.net trusty/main amd64 Packages
gnutls_handshake() failed: Handshake failed

sudo apt-get install redis-server -t trusty OK

sudo apt-get install libhiredis0.13 -t trusty FAIL maybe wrong version , it found 0.10 but not 0.13

E: Unable to locate package libhiredis0.13
E: Couldn't find any package by regex 'libhiredis0.13'

sudo apt-get install libtool autoconf dh-exec OK

sudo apt-get install libsairedis syncd FAIL

E: Unable to locate package libsairedis
E: Unable to locate package syncd

git clone https://github.com/sonic-net/sonic-sairedis.git FAIL - git used but not listed as prerequisite
```
bash: git: command not found
```
apt install git OK - added extra by me missing from steps
git clone https://github.com/sonic-net/sonic-sairedis.git OK
git submodule update --init --recursive FAIL - missing step specifying you need to be in the cloned folder
```
fatal: Not a git repository (or any of the parent directories): .git
```
cd ./sonic-sairedis/ OK - added extra by me missing from steps
git submodule update --init --recursive OK
sudo apt-get install libswsscommon libswsscommon-dev libhiredis-dev libzmq3-dev libpython-dev FAIL probably because that key was not added in first steps
```
E: Unable to locate package libswsscommon
E: Unable to locate package libswsscommon-dev
```
sudo apt-get install doxygen graphviz aspell OK

./autogen.sh FAIL

configure.ac:32: error: AM_COND_IF: no such condition "CODE_COVERAGE_ENABLED"
/usr/share/aclocal-1.14/cond-if.m4:23: AM_COND_IF is expanded from...
/usr/share/aclocal-1.14/cond-if.m4:23: AM_COND_IF is expanded from...
configure.ac:32: the top level
autom4te: /usr/bin/m4 failed with exit status: 1
aclocal: error: echo failed with exit status: 1
autoreconf: aclocal failed with exit status: 1

apt install autoconf-archive OK this fixed the error in autogen.sh for me in the past some dependency may be missing
./autogen.sh FAIL - some other needed deps are missing

kcudnik commented 1 month ago

is this issue still present? normally "apt install autoconf-archive" must be executed before to expand AM_COND_IF

sonic-net / sonic-sairedis

build instruction need update to latest debian version #1394