search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 273 forks source link

[fastboot] Notify SAI that fastboot is done #1396

Closed Junchao-Mellanox closed 1 month ago

Junchao-Mellanox commented 5 months ago

Why I did this

Notify SAI that fastboot is done

How I did this

Set SAI_SWITCH_ATTR_FAST_API_ENABLE to false when fastboot is done

How I verify this

Manual test

Junchao-Mellanox commented 5 months ago

Hi @yxieca , @vaibhavhd , could you please kindly review it?

kcudnik commented 5 months ago

Please fix errors

Junchao-Mellanox commented 5 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 5 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 5 months ago
Azure Pipelines successfully started running 1 pipeline(s).
yxieca commented 5 months ago

@adyeung can you get someone from Broadcom to assess this change?

adyeung commented 4 months ago

@tushar-ty @vishnushetty please help review

Junchao-Mellanox commented 4 months ago

Hi, please hod on the review for a moment. I will need to update this PR.

Junchao-Mellanox commented 4 months ago

Hi @tushar-ty @vishnushetty , could you please kindly provide comment?

Junchao-Mellanox commented 4 months ago

Hi @adyeung, @tushar-ty, @vishnushetty, kindly reminder.

adyeung commented 4 months ago

Adding @Prasanth-KV to help review

liat-grozovik commented 4 months ago

@Junchao-Mellanox can you check please the PR checker coverage issue?

Junchao-Mellanox commented 4 months ago

@Junchao-Mellanox can you check please the PR checker coverage issue?

Sure, working on it

Junchao-Mellanox commented 4 months ago

The new test case passed locally, but failed in github checker, I will investigate.

Junchao-Mellanox commented 4 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 4 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
Junchao-Mellanox commented 4 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 4 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 4 months ago
Azure Pipelines successfully started running 1 pipeline(s).
Junchao-Mellanox commented 4 months ago

Hi @kcudnik , could you please review and merge?

liat-grozovik commented 3 months ago

@saiarcot895 could you please help to merge?

dprital commented 3 months ago

Should be merged only after upstream of SAI version 2405.29.0.0. @Junchao-Mellanox , please mention it on PR description

Junchao-Mellanox commented 3 months ago

/azpw run Azure.sonic-sairedis

mssonicbld commented 3 months ago

/AzurePipelines run Azure.sonic-sairedis

azure-pipelines[bot] commented 3 months ago
Azure Pipelines successfully started running 1 pipeline(s).
liat-grozovik commented 2 months ago

@kcudnik can you please help to merge?

liat-grozovik commented 2 months ago

@saiarcot895 @kcudnik kindly reminder to merge this one

Junchao-Mellanox commented 1 month ago

Hi @kcudnik , could you please help merge this one?

bingwang-ms commented 2 days ago

@Junchao-Mellanox Auto-cherry-pick seems not working on this PR. Can you please raise a PR to 202405 branch?

Junchao-Mellanox commented 2 days ago

Backport PR: https://github.com/sonic-net/sonic-sairedis/pull/1468