search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 259 forks source link

Moving SAI failure dump handling above the ignore for non temp view #1402

Closed dgsudharsan closed 3 weeks ago

dgsudharsan commented 1 month ago

Fixes https://github.com/sonic-net/sonic-buildimage/issues/19411

During fast reboot temp view is not used and any failure will not result in SAI failure dump taken. Hence moving the handling of SAI failure dump above the ignore of non temp view.

dgsudharsan commented 1 month ago

@kcudnik Can you please review.

No new code was introduced and existing code was just moved. There was no coverage for the existing code as well

kcudnik commented 1 month ago

Please fix build issues and code coverage

dgsudharsan commented 1 month ago

Please fix build issues and code coverage

@kcudnik As mentioned in the previous comments its the existing code which I just moved. The existing code doesn't have coverage and I feel it is not within the scope of this PR to cover the existing code.

kcudnik commented 1 month ago

Unfortunately when you touch code that is not covered, code coverage must pass to be able to merge pr

dgsudharsan commented 3 weeks ago

@kcudnik Can you please merge this PR?

dgsudharsan commented 3 weeks ago

@kcudnik Can you please merge this PR?

dgsudharsan commented 2 weeks ago

@bingwang-ms Can you please cherry-pick this fix for 202405?

mssonicbld commented 2 weeks ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-sairedis/pull/1407