Closed dgsudharsan closed 3 weeks ago
@kcudnik Can you please review.
No new code was introduced and existing code was just moved. There was no coverage for the existing code as well
Please fix build issues and code coverage
Please fix build issues and code coverage
@kcudnik As mentioned in the previous comments its the existing code which I just moved. The existing code doesn't have coverage and I feel it is not within the scope of this PR to cover the existing code.
Unfortunately when you touch code that is not covered, code coverage must pass to be able to merge pr
@kcudnik Can you please merge this PR?
@kcudnik Can you please merge this PR?
@bingwang-ms Can you please cherry-pick this fix for 202405?
Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-sairedis/pull/1407
Fixes https://github.com/sonic-net/sonic-buildimage/issues/19411
During fast reboot temp view is not used and any failure will not result in SAI failure dump taken. Hence moving the handling of SAI failure dump above the ignore of non temp view.