search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
57 stars 272 forks source link

[saisubmodule] Update SAI submodule #1409

Closed jimmyzhai closed 2 months ago

jimmyzhai commented 3 months ago

Update SAI submodule to include https://github.com/opencomputeproject/SAI/pull/2026, which updates outbound_routing_entry. It updates serialization/deserialization, test, etc for outbound_routing_entry.

Includes the following SAI commits:

2024-07-23 684a8ee Mukesh Moopath Velayudhan: Add DPU acronym (#2053)
2024-07-18 7455ddf mikeberesford: Add port attribute to get the max debug data size. (#2033)
2024-07-15 dff0e34 Riff: Update DASH SAI API comments (#2050)
2024-07-15 8e74c55 Riff: Update DASH pipeline and HA related counters. (#2051)
2024-07-14 d15eca7 Kamil Cudnik: [meta][sai] Move extensions SAI and API to 0x20000000 range (#2028)
2024-07-10 19b30c1 chikkaiah-work: SAI proposal for icmp echo offload (#2020)
2024-06-27 18ba20f Marian Pritsak: [DASH] Add Routing Group API (#2026)
2024-06-25 abc8f02 Marian Pritsak: [DASH] Add missing prefixes to PL mapping (#2035)
kperumalbfn commented 3 months ago

@jimmyzhai Please update the PR description about adding serialize/deserialize change.

theasianpianist commented 3 months ago

Just FYI I have a PR that updates the submodule + also updates sairedis code for the route group API changes https://github.com/sonic-net/sonic-sairedis/pull/1410

jimmyzhai commented 3 months ago

@jimmyzhai Please update the PR description about adding serialize/deserialize change.

done

prabhataravind commented 3 months ago

@jimmyzhai, there are some more changes in public sairedis repo that includes metering related changes. Could you please help include those as well in this PR?

kcudnik commented 3 months ago

Please fix build errors

jimmyzhai commented 2 months ago

@jimmyzhai, there are some more changes in public sairedis repo that includes metering related changes. Could you please help include those as well in this PR?

Had tried that, but PR https://github.com/opencomputeproject/SAI/pull/2056 for metering changes caused other sairedis build failure, which is not easy to handle in this PR.

jimmyzhai commented 2 months ago

Please fix build errors

It depends on https://github.com/sonic-net/sonic-swss/pull/3048, which has fix for outbound_routing_entry changes in swss. The sairedis PR won't pass without the swss change, but the swss PR also won't pass without the sairedis PR. It's a sort of circular dependency.

After a discussion with Lawrence(theasianpianist), he had proposed the below solution:

  1. I will open my swss PR when it is ready, and also change the swss PR tests to use the artifacts from Junhua's submodule update PR
  2. Assuming that the PR tests pass with these changes, force merge Junhua's sairedis PR, then my swss PR.
  3. Finally submit another swss PR to change the PR test artifacts back to the latest build