search

sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project
Other
56 stars 273 forks source link

modify syncd init script for supporting yml #1411

Open geans-pin opened 3 months ago

linux-foundation-easycla[bot] commented 3 months ago

CLA Signed

The committers listed above are authorized under a signed CLA.

kcudnik commented 1 month ago

what is motivation here? please provide extended descrption for this pr

geans-pin commented 1 month ago

what is motivation here? please provide extended descrption for this pr

I had added the comment to remind this in HLD. Please check the PR of HLD

kcudnik commented 1 month ago

still not description in PR and seems like build is failing

geans-pin commented 1 month ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183

            #Overwrite section in common config should
            #be located after normal section

Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties

kcudnik commented 1 month ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183

            #Overwrite section in common config should
            #be located after normal section

Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties

here: https://github.com/sonic-net/sonic-sairedis/pull/1411#issue-2454592431 no description

geans-pin commented 3 weeks ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183

            #Overwrite section in common config should
            #be located after normal section

Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties

here: #1411 (comment) no description

With the new fix, we don't have this limitation. So, we don't need the comment now.

Geans

geans-pin commented 1 week ago

common config UT.pdf

geans-pin commented 1 week ago

/azpw run

mssonicbld commented 1 week ago

/AzurePipelines run

azure-pipelines[bot] commented 1 week ago
Azure Pipelines successfully started running 1 pipeline(s).
geans-pin commented 1 week ago

@ZhaohuiS

Can you help the checker failed ? In this PR, we don't change this src/singaler.cpp actually.

Geans

Assertion failed: pfd.revents & POLLIN (src/signaler.cpp:265) /bin/bash: line 6: 22075 Aborted (core dumped) ${dir}$tst FAIL: tests