sonic-net / sonic-sairedis

SAI object interface to Redis database, as used in the SONiC project

Other

56 stars 270 forks source link

modify syncd init script for supporting yml #1411

Open geans-pin opened 2 months ago

linux-foundation-easycla[bot] commented 2 months ago

:white_check_mark: login: geans-pin / name: 賓少鈺 (64baffdf49c193a466b59d9880922d40a710cf2f, ac3dec7126f5ded5717c7a6cf8265b6c39e21ce7, 4657857eb07cd35b8f1623777e150dfae846723a, b7f8d5c5b9ac7fd931e7b364e083c4b99f1551c6, ca167de28e7472d3a3282e70f3ab0e4a89a9ffd0, d8ef6fc8d9ef422e6d68edeb5fd1fd5e6089b339)
:x: - login: @geanspin . The commit (8e34b95da87a94f484b44355e574b0949caf2e0f, c8d7fec7fae112683d80a0fbf2595b1413076a9d, 0a5fcb799f38bddec485fa5757d191a9305787ec) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

kcudnik commented 1 month ago

what is motivation here? please provide extended descrption for this pr

geans-pin commented 3 weeks ago

what is motivation here? please provide extended descrption for this pr

I had added the comment to remind this in HLD. Please check the PR of HLD

kcudnik commented 3 weeks ago

still not description in PR and seems like build is failing

geans-pin commented 1 week ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183

            #Overwrite section in common config should
            #be located after normal section

Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties

kcudnik commented 1 week ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183
            #Overwrite section in common config should
            #be located after normal section
Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties

here: https://github.com/sonic-net/sonic-sairedis/pull/1411#issue-2454592431 no description

geans-pin commented 1 week ago

still not description in PR and seems like build is failing Can you check the latest commit in this PR ? on line 182 and 183
            #Overwrite section in common config should
            #be located after normal section
Also, in the HLD PR. Please check the following description.

Note, the Overwrite Section should be located after normal section in the common config file, otherwise the logic will overwrite all properties
here: #1411 (comment) no description

With the new fix, we don't have this limitation. So, we don't need the comment now.

Geans