search

sonic-net / sonic-snmpagent

A net-snmpd agentx subagent for SONiC
Other
15 stars 113 forks source link

Fix key missing exception when invalied transiver info in STATE_DB #289

Closed liuh-80 closed 1 year ago

liuh-80 commented 1 year ago

Fix PhysicalSensorTableMIBUpdater crash when 'type' attribute missing.

Work item tracking

Microsoft ADO (number only): 24869277

- What I did Fix PhysicalSensorTableMIBUpdater crash when 'type' attribute missing.

- How I did it Check 'type' attribute, if missing write error log in PhysicalSensorTableMIBUpdater.

- How to verify it Manually test. Pass all UT

- Description for the changelog Fix PhysicalSensorTableMIBUpdater crash when 'type' attribute missing.

ZhaohuiS commented 1 year ago

@liuh-80 Does this change need to be cherry picked into 202012, 202205, 202305?

StormLiangMS commented 1 year ago

@liuh-80 @qiluo-msft do we also need this on 202012?

qiluo-msft commented 1 year ago

No such bug on 202111 or earlier branches. This PR is needed on 202205, 202305, but these branches are not existing right now.

liuh-80 commented 1 year ago

@liuh-80 @qiluo-msft do we also need this on 202012?

We don't need this on 202012 because the code which has issue does not exist on 202012.