sonic-net / sonic-swss

SONiC Switch State Service (SwSS)
https://azure.github.io/SONiC
Other
176 stars 529 forks source link

[orchagent] orchagent crashes as implemenation missing for SAI_API_TUNNEL in handleSaiCreateStatus function #3015

Open skumar041 opened 9 months ago

skumar041 commented 9 months ago

Summary orchagent crashes as handle missing for SAI_API_TUNNEL in handleSaiCreateStatus. Orchaent shall handle SAI_STATUS_ATTR_NOT_SUPPORTED_3 error gracefully for all create only/create_and_set attributes if these attributes are not implemenetd in SAI.

SAIREDIS LOG :

2024-01-16.09:56:49.343556|c|SAI_OBJECT_TYPE_TUNNEL:oid:0x2a0000000007c0|SAI_TUNNEL_ATTR_TYPE=SAI_TUNNEL_TYPE_IPINIP|SAI_TUNNEL_ATTR_OVERLAY_INTERFACE=oid:0x60000000007bf|SAI_TUNNEL_ATTR_UNDERLAY_INTERFACE=oid:0x6000000000772|SAI_TUNNEL_ATTR_DECAP_ECN_MODE=SAI_TUNNEL_DECAP_ECN_MODE_COPY_FROM_OUTER|SAI_TUNNEL_ATTR_DECAP_TTL_MODE=SAI_TUNNEL_TTL_MODE_PIPE_MODEL|SAI_TUNNEL_ATTR_DECAP_DSCP_MODE=SAI_TUNNEL_DSCP_MODE_UNIFORM_MODEL

SYSLOG

Jan 16 09:56:49.345682 sonic NOTICE swss#orchagent: :- addDecapTunnel: Create overlay loopback router interface oid:60000000007bf Jan 16 09:56:49.357986 sonic ERR swss#orchagent: :- create: create status: SAI_STATUS_ATTR_NOT_SUPPORTED_3 Jan 16 09:56:49.357986 sonic ERR swss#orchagent: :- addDecapTunnel: Failed to create tunnel Jan 16 09:56:49.357986 sonic ERR swss#orchagent: :- handleSaiCreateStatus: Encountered failure in create operation, exiting orchagent, SAI API: SAI_API_TUNNEL, status: SAI_STATUS_ATTR_NOT_SUPPORTED_3 Jan 16 09:56:49.357986 sonic NOTICE swss#orchagent: :- notifySyncd: sending syncd: SYNCD_INVOKE_DUMP

/ Tunnel decap attributes /

/**
 * @brief Tunnel decap ECN mode
 *
 * @type sai_tunnel_decap_ecn_mode_t
 * @flags CREATE_ONLY
 * @default SAI_TUNNEL_DECAP_ECN_MODE_STANDARD
 */
SAI_TUNNEL_ATTR_DECAP_ECN_MODE,
prsunny commented 9 months ago

@prabhataravind to triage/fix