search

sonic-net / sonic-swss

SONiC Switch State Service (SwSS)
https://azure.github.io/SONiC
Other
173 stars 524 forks source link

Parse subport value added to config_db #3161

Closed bobbymcgonigle closed 5 months ago

bobbymcgonigle commented 5 months ago

What I did https://github.com/sonic-net/sonic-buildimage/pull/18499 Added support for subport values to be automatically calculated and inserted on creation of config_db.json. This change succeeds in adding the subport value into config_db.json - but it results in a log

WARNING #orchagent: message repeated 18564 times: [ :- parsePortConfig: Unknown field(subport): skipping ...]

being printed. This prevents the log being printed by handling the subport value.

Why I did it To prevent the orchagent log

How I verified it I manually tested on an Arista device that the log no longer appears

Details if related Question to reviews - should we assert on an unhandled/unknown field ? Rather than logging this message, it is easy to miss and the value still ends up in config_db

prsunny commented 5 months ago

Bypassing coverage to unblock other PRs

kcudnik commented 5 months ago

thanks for quick fix, i was alreay writting PR XD

mssonicbld commented 5 months ago

Cherry-pick PR to 202311: https://github.com/sonic-net/sonic-swss/pull/3166