Handle learning duplicate IPs on different VRFs

sonic-net / sonic-swss

SONiC Switch State Service (SwSS)

https://azure.github.io/SONiC

Other

173 stars 524 forks source link

Handle learning duplicate IPs on different VRFs #3165

Closed theasianpianist closed 5 months ago

theasianpianist commented 5 months ago

What I did Fixes https://github.com/sonic-net/sonic-buildimage/issues/18890

If we try to learn an existing neighbor on a different VLAN in the same VRF, delete the old neighbor entry before creating the new one.
For all other scenarios, proceed with neighbor learning normally.

Why I did it Allow learning the same IP in two different VRFs

How I verified it Run the C++ unit tests

Details if related

prsunny commented 5 months ago

@theasianpianist , can you fix coverage?

theasianpianist commented 5 months ago

@dgsudharsan Github is showing that you left some review comments, but I am unable to see them for some reason, can you please re-review w/ new changes?

keboliu commented 5 months ago

@theasianpianist would you please create a separate PR for 202311?