search

sonic-net / sonic-swss

SONiC Switch State Service (SwSS)
https://azure.github.io/SONiC
Other
170 stars 503 forks source link

Remove buffer maximum parameter table when the port is removed #3199

Closed stephenxs closed 1 month ago

stephenxs commented 2 months ago

What I did

Remove the buffer maximum parameter table entry when the port is removed.

Signed-off-by: Stephen Sun stephens@nvidia.com

Why I did it

To avoid the informational message handleBufferMaxParam: BUFFER_MAX_PARAM: Port Ethernet190 is not configured, need retry after the port is removed.

How I verified it

Unit test and manual test

Details if related

stephenxs commented 2 months ago

New UT fails without the fix as expected

[ RUN      ] PortsOrchTest.PortBulkCreateRemove
portsorch_ut.cpp:642: Failure
Value of: keys.empty()
  Actual: false
Expected: true
stephenxs commented 2 months ago

Failed due to ##[error]The agent did not connect within the alloted time of 45 minute(s).

stephenxs commented 2 months ago

/apzw run

stephenxs commented 2 months ago

/azpw run

mssonicbld commented 2 months ago

/AzurePipelines run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 1 pipeline(s).
stephenxs commented 2 months ago

/azpw run

mssonicbld commented 2 months ago

/AzurePipelines run

azure-pipelines[bot] commented 2 months ago
Azure Pipelines successfully started running 1 pipeline(s).
dprital commented 3 weeks ago

@bingwang-ms , Can you please cherry pick to 202405 ?

mssonicbld commented 3 weeks ago

Cherry-pick PR to 202405: https://github.com/sonic-net/sonic-swss/pull/3245