sonic-net / sonic-swss

SONiC Switch State Service (SwSS)
https://azure.github.io/SONiC
Other
170 stars 503 forks source link

Issue:SAI initializes break out ports as part of default vlan #3210

Open prasanna-cls opened 1 month ago

prasanna-cls commented 1 month ago

What I did

When port-break-out is created (new ports are created in SAI), Remove the vlan member for the [new-break-out-port, default-vlan] and default bridge port created for the new break-out ports that created by SAI.

Why I did it When SAI port OID is created as part of trigger from break-out operations, SAI makes this new port part of default vlan (creates a vlan member ) as well as creates a default bridge port. per sonic Orchagent, default vlan association or default bridge port creation must be done only as a part of operator configuration, cannot be SAI default.

How I verified it create port-break-out dynamically, ensure they are not a) part of default default vlan membership b) having any bridge port by default.

Which release branch to backport (provide reason below if selected)

202311 Details if related

Issue:SAI initializes break out ports as part of default vlan RCA:when a break out port is created in SAI, it make it as a vlan member for default vlan. Fix: after SAI creates a port, Orchagent gets the default vlan port membership, if any of the vlan member or bridge port is part of newly created portlist, then its removed.

prsunny commented 1 month ago

Please address coverage