search

sonic-net / sonic-swss

SONiC Switch State Service (SwSS)
https://azure.github.io/SONiC
Other
175 stars 525 forks source link

[fdborch/meta]: fdb event move handle problem #477

Open tylerlinp opened 6 years ago

tylerlinp commented 6 years ago

In test crm, we found that crm_stats_fdb_entry_used decreased to negative after mac moved several times between ports.

I think it maybe wrong in FdbOrch::update, MOVE simply remove entry like AGED not enough, should add a newer. So do meta_sai_on_fdb_event_single, no handle MOVE will lead to data inconsistency as bridge port changes.

Am i right?

prsunny commented 6 years ago

Did you test with the latest changes. There was a PR recently to fix incorrect update of FDB CRM counter.

https://github.com/Azure/sonic-swss/pull/461

tylerlinp commented 6 years ago

I test it in new version again, now after MOVE the counter can only decrease to zero rather than negative. I think it is a different problem, MOVE shouldn't cause decreasing, counter is 0 but actually used 1. Now crm counter is in keeping with fdborch entries, that's all right, owing to that PR. The key is MOVE event handling, now fdborch entries is inconsistency with ASIC_DB(syncd), entries moved are missing, meta data is inconsistency too which keeping old ports.