search

sonic-net / sonic-utilities

Command line utilities for the SONiC project
Other
152 stars 644 forks source link

Teamd crashes in case of specifying either negative or large positive value for "--min-links" key in the "config portchannel add " command #804

Open MaxYaremchuk opened 4 years ago

MaxYaremchuk commented 4 years ago

Description There is no validation, so it’s acceptable to specify either negative or large positive value for --min-links key in the config portchannel add command.

1-st case: # config portchannel add PortChannel0001 --min-links -3 2-nd case: # config portchannel add PortChannel0001 --min-links 9999

Steps to reproduce the issue 1.# config portchannel add PortChannel0001 --min-links **-3** 2.# config portchannel add PortChannel0001 --min-links **9999**

Describe the results you received Both scenarios cause teamd crashes. Syslog: Teamd crashes with :

Jan 28 21:27:10.651036 sonic ERR teamd#teammgrd: :- main: Runtime error: stoi
Jan 28 21:27:11.654010 sonic INFO teamd#supervisor-proc-exit-listener: Process teammgrd exited unxepectedly. Terminating supervisor...
Jan 28 21:27:13.795446 sonic INFO containerd[563]: time="2020-01-28T21:27:13.795281836Z" level=info msg="shim reaped" id=a898a3ab008c14c65b0e7227e8592eedb59e570861218f2cb00cb645a8fdeb60
Jan 28 21:27:13.805514 sonic INFO dockerd[751]: time="2020-01-28T21:27:13.805388382Z" level=info msg="ignoring event" module=libcontainerd namespace=moby topic=/tasks/delete type="*events.TaskDelete" 
Jan 28 21:27:13.878407 sonic INFO teamd.sh[7074]: 0
Jan 28 21:27:13.926660 sonic INFO teamd.sh[11288]: teamd```

Docker containers:

root@r-qa-sw-eth-21138:/home/admin# docker ps
CONTAINER ID        IMAGE                                COMMAND                  CREATED             STATUS              PORTS               NAMES
6f4b64f1b66b        docker-sonic-telemetry:latest        "/usr/bin/supervisord"   33 hours ago        Up 55 seconds                           telemetry
6785b1121b84        docker-sonic-mgmt-framework:latest   "/usr/bin/supervisord"   33 hours ago        Up 4 minutes                            mgmt-framework
6f73266b584d        docker-snmp-sv2:latest               "/usr/bin/supervisord"   4 days ago          Up 53 seconds                           snmp
bef5fc1a17d9        docker-dhcp-relay:latest             "/usr/bin/docker_ini…"   4 days ago          Up 4 minutes                            dhcp_relay
8e4bf2266117        docker-lldp-sv2:latest               "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            lldp
54ba15383712        docker-platform-monitor:latest       "/usr/bin/docker_ini…"   4 days ago          Up 4 minutes                            pmon
46fc9bbe2307        docker-router-advertiser:latest      "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            radv
64c529471167        docker-sflow:latest                  "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            sflow
efec372f0742        docker-syncd-mlnx:latest             "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            syncd
7704a37bfdcc        docker-orchagent:latest              "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            swss
e8a9ab9fb647        docker-fpm-frr:latest                "/usr/bin/supervisord"   4 days ago          Up 4 minutes                            bgp
1a672ab3c428        docker-database:latest               "/usr/local/bin/dock…"   4 days ago          Up 4 minutes                            database

Describe the results you expected Config utility should prevent from assigning either negative or large positive value for --min-links key in the config portchannel add command.

Output of show version

SONiC Software Version: SONiC.master.0-dirty-20200114.131506
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 952dfb15
Build date: Tue Jan 14 13:28:50 UTC 2020
Built by: volodymyrs@r-build-sonic03

Platform: x86_64-mlnx_msn2100-r0
HwSKU: ACS-MSN2100
ASIC: mellanox
Serial Number: MT1646X05314
Uptime: 14:37:13 up 32 min,  2 users,  load average: 0.00, 0.01, 0.16

Docker images:
REPOSITORY                    TAG                              IMAGE ID            SIZE
docker-platform-monitor       latest                           aabdbf5b55b9        569MB
docker-platform-monitor       master.0-dirty-20200114.131506   aabdbf5b55b9        569MB
docker-sflow                  latest                           acc6d9a905f3        306MB
docker-sflow                  master.0-dirty-20200114.131506   acc6d9a905f3        306MB
docker-fpm-frr                latest                           2e17fdf8f565        325MB
docker-fpm-frr                master.0-dirty-20200114.131506   2e17fdf8f565        325MB
docker-syncd-mlnx             latest                           09df8b1f23d7        377MB
docker-syncd-mlnx             master.0-dirty-20200114.131506   09df8b1f23d7        377MB
docker-orchagent              latest                           6729c2e779af        323MB
docker-orchagent              master.0-dirty-20200114.131506   6729c2e779af        323MB
docker-teamd                  latest                           a710f94fa26c        305MB
docker-teamd                  master.0-dirty-20200114.131506   a710f94fa26c        305MB
docker-snmp-sv2               latest                           e4c726145422        339MB
docker-snmp-sv2               master.0-dirty-20200114.131506   e4c726145422        339MB
docker-lldp-sv2               latest                           d67cfab77277        303MB
docker-lldp-sv2               master.0-dirty-20200114.131506   d67cfab77277        303MB
docker-sonic-mgmt-framework   latest                           544660d56163        330MB
docker-sonic-mgmt-framework   master.0-dirty-20200114.131506   544660d56163        330MB
docker-sonic-telemetry        latest                           7df4698f004b        343MB
docker-sonic-telemetry        master.0-dirty-20200114.131506   7df4698f004b        343MB
docker-sonic-restapi          latest                           6834d43af7fb        293MB
docker-sonic-restapi          master.0-dirty-20200114.131506   6834d43af7fb        293MB
docker-router-advertiser      latest                           2fa815e41d75        282MB
docker-router-advertiser      master.0-dirty-20200114.131506   2fa815e41d75        282MB
docker-database               latest                           681324505d5c        282MB
docker-database               master.0-dirty-20200114.131506   681324505d5c        282MB
docker-dhcp-relay             latest                           a3dfa0aa88e9        292MB
docker-dhcp-relay             master.0-dirty-20200114.131506   a3dfa0aa88e9        292MB

sonic_dump_r-qa-sw-eth-21138_20200128_211943.tar.gz sonic_dump_r-qa-sw-eth-21138_20200128_212736.tar.gz

Hedgehog-Guru commented 3 years ago

The bug has been fixed by the community under the latest branch 201911, hash dea38d1