search

sonic-net / sonic-utilities

Command line utilities for the SONiC project
Other
157 stars 663 forks source link

Missing validation of adding a vlan member port to a portchannel interface. #806

Open MaxYaremchuk opened 4 years ago

MaxYaremchuk commented 4 years ago

Description The config portchannel member add command doesn't check whether added interface is a vlan member.

Although such added port has not been added to portchannel, but if running configuration is saved it will lead to system crashes during next system rebooting.

Steps to reproduce the issue

  1. Add a vlan # config vlan add 2
  2. Add a vlan member # config vlan member add 2 Ethernet0
  3. Create a portchannel interface and add a trunk port from previous step to this portchannel # config portchannel add PortChannel0001 # config portchannel member add PortChannel0001 Ethernet0
  4. Save config & reboot

Describe the results you received after rebooting docker containers crashes:

Jan 31 14:06:15.884601 r-ethernet-sw230 INFO swss.sh[4327]: No longer waiting on container 'swss'
Jan 31 14:06:15.917034 r-ethernet-sw230 NOTICE root: Stopping swss service...
Jan 31 14:06:15.925050 r-ethernet-sw230 NOTICE root: Locking /tmp/swss-syncd-lock from swss service
Jan 31 14:06:15.935367 r-ethernet-sw230 NOTICE root: Locked /tmp/swss-syncd-lock (10) from swss service
Jan 31 14:06:16.476376 r-ethernet-sw230 NOTICE root: Warm boot flag: swss false.
Jan 31 14:06:16.574305 r-ethernet-sw230 INFO swss.sh[8081]: swss
Jan 31 14:06:16.583619 r-ethernet-sw230 NOTICE root: Stopped swss service...
Jan 31 14:06:16.592959 r-ethernet-sw230 NOTICE root: Clearing FAST_REBOOT flag...
Jan 31 14:06:16.877283 r-ethernet-sw230 NOTICE root: Unlocking /tmp/swss-syncd-lock (10) from swss service
Jan 31 14:06:16.891342 r-ethernet-sw230 INFO systemd[1]: Stopping syncd service...
Jan 31 14:06:16.902501 r-ethernet-sw230 NOTICE root: Stopping syncd service...
Jan 31 14:06:16.911261 r-ethernet-sw230 NOTICE root: Locking /tmp/swss-syncd-lock from syncd service
Jan 31 14:06:16.924477 r-ethernet-sw230 NOTICE root: Locked /tmp/swss-syncd-lock (10) from syncd service
Jan 31 14:06:17.490516 r-ethernet-sw230 NOTICE root: Warm boot flag: syncd false.
Jan 31 14:06:17.499564 r-ethernet-sw230 NOTICE root: Stopping pmon service ahead of syncd...
Jan 31 14:06:17.513570 r-ethernet-sw230 INFO systemd[1]: Stopping Platform monitor container..

Describe the results you expected

  1. An attempt to add a trunk interface to portchannel interface should be rejected and these missguided settings must not be saved in running configuration.
  2. There should be cli/syslog warning in case of assigning a vlan member port to a portchannel interface.

Additional information you deem important (e.g. issue happens only occasionally)

Output of show version

SONiC Software Version: SONiC.master.0-dirty-20200114.131506
Distribution: Debian 9.11
Kernel: 4.9.0-9-2-amd64
Build commit: 952dfb15
Build date: Tue Jan 14 13:28:50 UTC 2020
Built by: volodymyrs@r-build-sonic03

Platform: x86_64-mlnx_msn2100-r0
HwSKU: ACS-MSN2100
ASIC: mellanox
Serial Number: MT1646X05314
Uptime: 14:37:13 up 32 min,  2 users,  load average: 0.00, 0.01, 0.16

Docker images:
REPOSITORY                    TAG                              IMAGE ID            SIZE
docker-platform-monitor       latest                           aabdbf5b55b9        569MB
docker-platform-monitor       master.0-dirty-20200114.131506   aabdbf5b55b9        569MB
docker-sflow                  latest                           acc6d9a905f3        306MB
docker-sflow                  master.0-dirty-20200114.131506   acc6d9a905f3        306MB
docker-fpm-frr                latest                           2e17fdf8f565        325MB
docker-fpm-frr                master.0-dirty-20200114.131506   2e17fdf8f565        325MB
docker-syncd-mlnx             latest                           09df8b1f23d7        377MB
docker-syncd-mlnx             master.0-dirty-20200114.131506   09df8b1f23d7        377MB
docker-orchagent              latest                           6729c2e779af        323MB
docker-orchagent              master.0-dirty-20200114.131506   6729c2e779af        323MB
docker-teamd                  latest                           a710f94fa26c        305MB
docker-teamd                  master.0-dirty-20200114.131506   a710f94fa26c        305MB
docker-snmp-sv2               latest                           e4c726145422        339MB
docker-snmp-sv2               master.0-dirty-20200114.131506   e4c726145422        339MB
docker-lldp-sv2               latest                           d67cfab77277        303MB
docker-lldp-sv2               master.0-dirty-20200114.131506   d67cfab77277        303MB
docker-sonic-mgmt-framework   latest                           544660d56163        330MB
docker-sonic-mgmt-framework   master.0-dirty-20200114.131506   544660d56163        330MB
docker-sonic-telemetry        latest                           7df4698f004b        343MB
docker-sonic-telemetry        master.0-dirty-20200114.131506   7df4698f004b        343MB
docker-sonic-restapi          latest                           6834d43af7fb        293MB
docker-sonic-restapi          master.0-dirty-20200114.131506   6834d43af7fb        293MB
docker-router-advertiser      latest                           2fa815e41d75        282MB
docker-router-advertiser      master.0-dirty-20200114.131506   2fa815e41d75        282MB
docker-database               latest                           681324505d5c        282MB
docker-database               master.0-dirty-20200114.131506   681324505d5c        282MB
docker-dhcp-relay             latest                           a3dfa0aa88e9        292MB
docker-dhcp-relay             master.0-dirty-20200114.131506   a3dfa0aa88e9        292MB

sonic_dump_r-ethernet-sw230_20200131_140708.tar.gz

prsunny commented 4 years ago

this is a known limitation. I believe, this would be handled by the management framework

Hedgehog-Guru commented 3 years ago

Bug moved to https://github.com/Azure/sonic-buildimage/issues/6427