sonic-pi-net / sonic-pi

Code. Music. Live.
https://sonic-pi.net
Other
10.75k stars 918 forks source link

Behaviour of list_synths #1053

Closed rbnpi closed 8 years ago

rbnpi commented 8 years ago

Currenty list_synths gives the following. Is this what is expected including all the fx as well as basic_mono_player and basic_stereo_player? Needs a more restrictive list to just get playable synths to choose from list.

(ring :dull_bell, :pretty_bell, :beep, :sine, :saw, :pulse, :subpulse, :square, :tri, :dsaw, :dpulse, :dtri, :fm, :mod_fm, :mod_saw, :mod_dsaw, :mod_sine, :mod_beep, :mod_tri, :mod_pulse, :chiplead, :chipbass, :tb303, :supersaw, :hoover, :prophet, :zawa, :dark_ambience, :growl, :hollow, :mono_player, :stereo_player, :blade, :piano, :pluck, :sound_in, :noise, :pnoise, :bnoise, :gnoise, :cnoise, :chipnoise, :basic_mono_player, :basic_stereo_player, :basic_mixer, :main_mixer, :fx_bitcrusher, :fx_krush, :fx_reverb, :fx_gverb, :fx_replace_reverb, :fx_level, :fx_mono, :fx_replace_level, :fx_echo, :fx_replace_echo, :fx_slicer, :fx_panslicer, :fx_replace_slicer, :fx_wobble, :fx_replace_wobble, :fx_ixi_techno, :fx_replace_ixi_techno, :fx_compressor, :fx_whammy, :fx_replace_compressor, :fx_rlpf, :fx_replace_rlpf, :fx_nrlpf, :fx_replace_nrlpf, :fx_rhpf, :fx_replace_rhpf, :fx_nrhpf, :fx_replace_nrhpf, :fx_hpf, :fx_replace_hpf, :fx_nhpf, :fx_replace_nhpf, :fx_lpf, :fx_replace_lpf, :fx_nlpf, :fx_replace_nlpf, :fx_normaliser, :fx_replace_normaliser, :fx_distortion, :fx_replace_distortion, :fx_pan, :fx_replace_pan, :fx_bpf, :fx_nbpf, :fx_rbpf, :fx_nrbpf, :fx_band_eq, :fx_tanh, :fx_pitch_shift, :fx_ring_mod, :fx_octaver, :fx_vowel, :fx_flanger)

ethancrawford commented 8 years ago

@samaaron: would adding a method to all the synth declarations in synthinfo.rb like this:

def user_facing?
  true
end

and using that to filter the list of SynthNodes, be suitable? (In which case I can have a PR up shortly)

samaaron commented 8 years ago

@ethancrawford I think that's probably a good idea. You wouldn't need to add that code to all declarations, just in the relevant parent classes :-)

ethancrawford commented 8 years ago

See https://github.com/samaaron/sonic-pi/pull/1104 for a possible solution.

ethancrawford commented 8 years ago

@rbnpi - #1104 has been merged - happy to close this now?

rbnpi commented 8 years ago

Yes fine now. will close. Thanks!