Closed floholl closed 1 week ago
Awesome - any chance you could create a PR fixing this?
Sure, I'll give it a try (first such occasion, so will first need to find language reference sources in the repository whenever I have a moment).
I just submitted pull request #3426 to the best of my ability. For future reference, here is the procedure I followed, based on these instructions. Feel free to (gently) correct. 🙃
$ git clone git@github.com:floholl/sonic-pi.git
use_random_source
in vim:
$ cd sonic-pi
$ vim app/server/ruby/lib/sonicpi/lang/core.rb
:%s/rand_type/use_random_source/gc
:wq
$ git add app/server/ruby/lib/sonicpi/lang/core.rb
$ git commit -m "Replace rand_type with use_random_source in lang reference entry for the latter"
$ git push
Should I (generally) close an issue for which a pull request was requested once that's been taken care of? Or should I wait until the pull request has been merged? (I'll leave this one open for now.)
I'm just watching the repo but here's my two cents.
Should I (generally) close an issue for which a pull request was requested once that's been taken care of? Or should I wait until the pull request has been merged? (I'll leave this one open for now.)
What seems to be the preferred way on Github is to leave an issue open until the PR is merged.
Btw, you should just be able to say closes #3425
in your PR description and Github will automatically close the issue when the PR is merged.
Closing this after pull request #3426 has been merged.
The following applies to Sonic Pi v4.5.0 under macOS (Apple silicon):
In the Sonic Pi language reference that comes with the app, the documentation for
use_random_source
includes the following code excerpt just before the Examples section:However, this code fails to run in the given Sonic Pi version, due to the reference to
rand_type
, which I'm guessing has been renamed touse_random_source
at some point. The code works if all references are replaced accordingly to:Reporting this as a required update to the documentation.