Nxm urlscheme robustness

sonic2kk / steamtinkerlaunch

Linux wrapper tool for use with the Steam client for custom launch options and 3rd party programs

GNU General Public License v3.0

2.03k stars 69 forks source link

Nxm urlscheme robustness #1096

Closed zerodogg closed 2 months ago

zerodogg commented 2 months ago

This PR fixes a few things with MO2 handling:

There should no longer be an inconsistency between the last MO2 config written (global or portable) and STL's understanding of which MO2 variant was last used (global or portable)
Global instances now set the same vars as portable, which should fix launching global MO2s in those instances where it's missing the same vars as the portable was
It no longer writes useless broken portable config files when it can't figure out the game name
It'll fall back to using an AID to detect the game name, if one is present, which should fix those cases where MO2GAM for some reason isn't set (should fix #1093)

sonic2kk commented 2 months ago

Awesome work! I'll review a little deeper when I'm on my PC, and give OP from #1093 some time to test the patch if they're able to. From a quick skim on my phone though and reading your description, it looks reasonable :-)

This has been a longstanding issue, so getting it resolved will make plenty of people very happy. And either way I appreciate the time you took to contribute as well!

Side note: Nice to see the CI working 😄

sonic2kk commented 2 months ago

I think we can merge this as-is. I'd like to get this in before #1100, and I don't want to cause any more headaches with keeping this branch up-to-date. I think OP can test this on master when they are free to :slightly_smiling_face:

I think the rebase went OK, if you see anything wrong with the diff, let me know :-)

Thanks!

sonic2kk commented 2 months ago

Added credit to the changelog by updating the part that notes you improved the NXM link handling already, now it links to both PRs as they both help here: https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog