One-Time Run: Default to per-game Proton version if `--proton` is not passed

sonic2kk commented 2 weeks ago

This PR allows for running One-Time Run without passing a Proton version. If the Proton version given is blank, or if --proton= is omitted entirely, we will fall back to the per-game Proton version, "USEPROTON".

If the per-game Proton version USEPROTON does not exist in ProtonCSV.txt (perhaps there have been Proton updates, or the game has not been launched in a long time and the value is a very old GE-Proton version) then we will resolve the mismatch using the USEPROTON.

This PR also fixes an issue with commandline One-Time Run where blank values were not being resolved correctly, because fixProtonVersionMismatch does not run unless ISGAME -eq 2, which is not guaranteed to be the case with One-Time Run if launched outside of Steam. Therefore, if we get far enough into the commandlineOneTimeRun function that we think we need to use Proton, we will force fixProtonVersionMismatch by passing a new argument FORCEPROTONMISMATCHRESOLVE which defaults to 0 if not passed to preserve existing functionality.

With that fixProtonVersionMismatch alone, it meant that it would've returned the first item in ProtonCSV if the mismatch version to resolve was blank (i.e. if --proton was not passed), which is not ideal. Instead this PR has extra functionality to make fixProtonVersionMismatch fall back to the per-game Proton version if RUNOTPROTON is blank (i.e. if --proton is not passed).

As a result, this PR means the following lines work:

steamtinkerlaunch otr --exe="/path/to/valid/exe" - This previously would not have worked because fixProtonVersionMismatch would not have ran, so the EXE would not run
- With this PR, not only is this fixed, but we will fall back to the per-game Proton version instead of relying on fixProtonVersionMismatch to return whatever the first Proton value is in ProtonCSV
steamtinkerlaunch otr --exe="/path/to/valid/exe" --proton="invalid-proton" - This was previously meant to work by resolving with fixProtonVersionMismatch, but this would have usually failed because the function was not running at all if ISGAME was not 3. Now it will attempt to resolve the mismatch.

There are some things left to do in this PR, mainly I want to check to see if OTPROTON needs to be updated after a Proton version mismatch. Logically it seems to me that it should, since it is only set to the value given by --proton="" in the form of RUNOTPROTON, but as we can update this value to resolve mismatches if it is invalid, that means OTPROTON could be left being an invalid Proton version; that is, whatever RUNOTPROTON was originally set to.

TODO:

[x] Further testing
[x] Check if OTPROTON and other saving behaviour needs updated after RUNOTPROTON gets updated for a Proton version mismatch resolution
[x] Version bump