Closed sonic2kk closed 10 months ago
Tested with just passing the game name and enabling SteamGridDB (no Game ID/App ID/Game Name passed at all) and it worked for Cake Mania!
Next we need to test Game ID, Steam AppID, and game name individually, and then test the fallbacks to make sure they work.
We need to test from the commandline as well after all of this too, ideally the same cases.
Entering a custom game name to search on will correctly use that instead of the App Name!
On the UI front, this appears to be mostly working as expected.
Commandline has not been tested extensively yet, but it should work since the UI just uses the commandline options.
Functionally, this feature is complete, but we need to update the wiki to note these changes, and fix the UI sizing issue.
Wiki overhaul is ready to go, we just need to finish up this PR!
Commandline usage seems to not work...
It seems that if --use-steamgriddb
is not passed, then no artwork is fetched, even if other fields are provided. When it is passed, everything works as expected.
So I need to figure out and fix this, as --use-steamgriddb
should not be required on the commandline.
Menu is now scrollable, so we should just have to update the langfiles now and be good to go!
Langfiles should be synced up now, will do a couple of final tests and then bump the version and merge!
Shellcheck is good, testing with and without SteamGridDB works (including local game art), SteamGridDB is only fetched on GUI when SteamGridDB is enabled, auto enabled if any fields are passed on commandline, and all fallbacks work as expected. This is good to merge!
Another big piece of work for #933.
Overview
This PR overhauls the SteamGridDB options for Add Non-Steam Game, with the following changes:
--use-steamgriddb
flag to specify that we want to search using SteamGridDB--sgnm
flag to search on a name--sgai
flag to search on Steam AppID--use-steamgriddb
automatically--use-steamgriddb
is specified, fall back to searching for SteamGridDB Game ID using Non-Steam Game NameThis still needs in-depth testing, but initial testing is promising!
Remaining work
However, there is an issue with the GUI. Right now it is too big to display as a dialogue on regular 1080p displays, and even when maximised it hides the buttons at the bottom. This makes it pretty much unusable, so we'll need to make it scrollable or something.
We also have to update the helpscreen and wiiki with these new parameters.
TODO: