search

sonicmax / ChromeLL-2.0-for-Firefox

1 stars 0 forks source link

Bugs/problems/annoyances caused by Firefox port #1

Closed sonicmax closed 6 years ago

sonicmax commented 6 years ago

Just so I can keep track of what was changed and what needs changing

  1. "Type error for parameter options (Property "buttons" is unsupported by Firefox) for notifications.create." This one is weird because their docs seem to explicitly mention being able to create notifications with buttons, as you can in Chrome. No mention of compatibility issues or anything. (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/3f6c022c30a20b972f6cfbaa9bb8fcf2bb3c7b18)

  2. Firefox won't let you access objects in allPages.js from other content scripts? (not sure if this was me being an idiot, or a legitimate difference in context script loading order/matches/etc, but it's fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/9073a9f51dc442ccac1c0dcdd52983b651da8879)

  3. Modifying ETI CSS throws DOMException (insecure operation) https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/9395da75938ad91c75c78025b71a94ea8e060062 (easy fix, but still annoying because you can only see where the error is thrown by using try-catch block.)

  4. Can't use browser.webRequest from content scripts (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/794f49d744fb2b86233ddf8efd8b73cd562e44fc)

  5. The options menu CSS looks weird. (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/6dcdc59685eb096041da572508acab62ca18f41c)

  6. The Firefox APIs use Promises instead of callbacks (mostly complete, not committed). This wasn't so bad once I figured out that promise chaining was a thing Pretty much fixed

  7. Transparency in notifications? No idea whether this is a browser setting or programmable or whether it's just stuck like that

  8. The hoverIntent jQuery plugin seems to be broken (figured this out - see 11)

  9. Batch drop uploader doesn't work (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/8725876b77d3355acb92c362bcbef38f15710cf2)

  10. Can't use progress notifications - need to replace these with basic notification (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/a9319c66c885ac912e5f7c9c002b61da59454a07

  11. jQuery doesn't work if loaded at document_start. Not sure why this only happens in Firefox, but whatever (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/f49c2cb57318915e49dcc3c4ee869f81ae3577b9)

  12. Can't use window methods in background script - so "rename and transload" feature fails when trying to open prompt. We need to inject a script into each page to handle this (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/1bbf0682178ebd2eef04f99da514559257dddff6)

  13. Badge text for browser action doesn't reset after navigating to new page (fixed https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/c5973b61c0fe28bd1f9e06dcac4c13c6701648b4 & this is fixed properly in Firefox 58)

sonicmax commented 6 years ago

Published the update and everything seems ok, fingers crossed

sonicmax commented 6 years ago
  1. Firefox doesn't support HTMLDialogElement.showModal() (added polyfill https://github.com/sonicmax/ChromeLL-2.0-for-Firefox/commit/ecb1b230288623990d55e97c3ab352331ddc70c4)