This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ng2-translate.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
make TranslateParser public (df7fe29c, closes #347)
emit all translations on merge instead of just added ones (807cb15d, closes #367)
Translate Directive:
the directive listens to onTranslationChange events now (20881950
Features
Added default fallback language to English (15a75c24)
TranslationService: getting translations for default lang when it's set (20881950, closes #332, #336)
Breaking Changes
we will now fetch the translations for the default lang when it is set (if they are not already available). Also the default lang is now automatically set to the first lang that receives translations (if it is still undefined at that time). Setting the default lang will override this default behavior, so this will probably not break anything for you, but if you set the translations for the default lang first then you don't even have to call setDefaultLang anymore.
df7fe29fix(TranslateService): make TranslateParser public
807cb15fix(TranslateService): emit all translations on merge instead of just added ones
13bb77ftest(npm): fixed karma-remap-coverage version
b798cc6docs(README): Fix wrong key for the parameters of the directive
d664d28docs(example): added copy-webpack-plugin for webpack
b404188docs(README): fixing font case for directive
fcb8edbdocs(README): Add ng2-translate-extract link
3b3451aAdded tests for DefaultLangChange event in pipe and removed the translations argument from the DefaultLangChange events in the pipe and the directive
f3a2f5edocs(README): adding a note for systemjs users
8e40a4eAdded onDefaultLangChangeEvent subscription to directive and moved get default language translations from getParsedResult to setDefaultLang as setting the default language should emit an event with the translations for the default language. In theory the setDefaultLang function should work about the same way as the use function.
5aced58Updated README.md by adding documentation about the newly added DefaultLangChangeEvent
Hello lovely humans,
ng2-translate just published its new version 5.0.0.
This version is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of ng2-translate. Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right? Are you unsure about how things are supposed to work?
There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.
Good luck with your project :sparkles:
You rock!
:palm_tree:
GitHub Release
5.0.0 (2016-12-20)
Bug Fixes
TranslateService:
Translate Directive:
onTranslationChange
events now (20881950Features
Breaking Changes
we will now fetch the translations for the default lang when it is set (if they are not already available). Also the default lang is now automatically set to the first lang that receives translations (if it is still undefined at that time). Setting the default lang will override this default behavior, so this will probably not break anything for you, but if you set the translations for the default lang first then you don't even have to call
setDefaultLang
anymore.(20881950)
The new version differs by 20 commits .
38ab093
Merge branch 'pndewit-master'
2088195
feat(TranslationService): getting translations for default lang when it's set
38e0cd9
Merge branch 'master' of https://github.com/pndewit/ng2-translate into pndewit-master
7cb84e0
chore(npm): updated dependencies
df7fe29
fix(TranslateService): make TranslateParser public
807cb15
fix(TranslateService): emit all translations on merge instead of just added ones
13bb77f
test(npm): fixed karma-remap-coverage version
b798cc6
docs(README): Fix wrong key for the parameters of the directive
d664d28
docs(example): added copy-webpack-plugin for webpack
b404188
docs(README): fixing font case for directive
fcb8edb
docs(README): Add ng2-translate-extract link
3b3451a
Added tests for DefaultLangChange event in pipe and removed the translations argument from the DefaultLangChange events in the pipe and the directive
f3a2f5e
docs(README): adding a note for systemjs users
8e40a4e
Added onDefaultLangChangeEvent subscription to directive and moved get default language translations from getParsedResult to setDefaultLang as setting the default language should emit an event with the translations for the default language. In theory the setDefaultLang function should work about the same way as the use function.
5aced58
Updated README.md by adding documentation about the newly added DefaultLangChangeEvent
There are 20 commits in total. See the full diff.
This pull request was created by greenkeeper.io.
Tired of seeing this sponsor message? :zap:
greenkeeper upgrade