search

sonicretro / mania-mod-loader

Mod loader for Mania.
44 stars 6 forks source link

Issue with ModManager reading mod.ini in the mods folder #10

Open thesupersonic16 opened 7 years ago

thesupersonic16 commented 7 years ago

I haven't written an issue in a very long time.

So it looks like ManiaModManager is trying to load mod.ini from Sonic Mania/mods/mod.ini and is failing to substring the path.

The issue is that the ModManager is failing to substring the path for the key because its trying to get the directory name by removing the mods directory path plus a slash(I guess), which will not work if the mod.ini is in the mods directory, The exception is thrown at line 217 in MainForm.cs when mod.ini exists in the mods directory.

I have no idea if you wanted the mods directory to be a mod.

MainMemory commented 7 years ago

No, there shouldn't be a mod.ini file in the mods folder. I don't know where you're getting one from, but it's not included with the mod loader.

thesupersonic16 commented 7 years ago

Its not included, but some people are extracting mod.ini in their mods folder which causes the ModManager to throw an exception.

MainMemory commented 7 years ago

Well then people should include the folder in their mod packages, like I do.

I guess I could try to add some kind of warning about having mod.ini in the mods folder.

thesupersonic16 commented 7 years ago

That should help.