Instead of having simple numbered names for these routines, I believe it's better to tell what these routines actually do in their name. The changes are as followed:
PalLoad1: Changed to PalLoad_Fade, as this loads the palette into a buffer (v_pal_dry_dup) that's read from the PaletteFadeIn routine. When PaletteFadeIn is called, it's copied from v_pal_dry_dup into v_pal_dry.
PalLoad2: Changed to PalLoad, as this directly loads the palette into v_pal_dry. v_pal_dry is always copied to CRAM in VBLANK.
PalLoad3: Changed to PalLoad_Fade_Water. This is the same as PalLoad1/PalLoad_Fade, but for the underwater palette.
PalLoad4: Changed to PalLoad_Water. This is the same as PalLoad2/PalLoad, but for the underwater palette.
I would additionally suggest changing v_pal_dry to simply v_palette, given the distinction between the above water and underwater palettes is only useful in Labyrinth Zone. This variable name suggestion is not included in this pull request,
Instead of having simple numbered names for these routines, I believe it's better to tell what these routines actually do in their name. The changes are as followed:
PalLoad1: Changed toPalLoad_Fade, as this loads the palette into a buffer (v_pal_dry_dup) that's read from thePaletteFadeInroutine. WhenPaletteFadeInis called, it's copied fromv_pal_dry_dupintov_pal_dry.PalLoad2: Changed toPalLoad, as this directly loads the palette intov_pal_dry.v_pal_dryis always copied to CRAM in VBLANK.PalLoad3: Changed toPalLoad_Fade_Water. This is the same asPalLoad1/PalLoad_Fade, but for the underwater palette.PalLoad4: Changed toPalLoad_Water. This is the same asPalLoad2/PalLoad, but for the underwater palette.I would additionally suggest changing
v_pal_dryto simplyv_palette, given the distinction between the above water and underwater palettes is only useful in Labyrinth Zone. This variable name suggestion is not included in this pull request,