Found a pretty big bug!!!

[jackttcoms]

Ok! I have created a simple blog and im using a foreach to get the data but when there is only one result in the db i get a tonne of odd errors!

The bit of code that is causing this error:

        if(empty($data)) { 
            return false; // return FALSE
        } elseif (count($data) > 1) {
            return $data; // return full index of records.
        } else {
            return $data[0]; // return single record.
        }

I tried changing it to this but unfortunately this then broke the login:

        if(empty($data)) { 
            return false; // return FALSE
        } elseif (count($data) => 1) {
            return $data; // return full index of records.
        } else {
            return $data[0]; // return single record.
        }

---

Here is my code, maybe i have done something wrong:

                        <?php foreach($data as $post) : ?>

                            <div class="col-lg-6 col-md-6 padding15">
                                <div class="card shadow-2 mb-3"><a href="<?php echo FULL_ROOT; ?>/blog/post/<?php echo $post['id']; ?>"><img class="card-img-top w-100 d-block" src="<?php echo FULL_ROOT; ?>/uploads/blog/<?php echo $post['image']; ?>"></a>
                                    <div class="card-body pb-0">
                                        <ul class="list-inline mb-1">
                                            <li class="list-inline-item"><a href="<?php echo FULL_ROOT; ?>/blog/category/<?php echo $post['cat_id']; ?>">Blog Tag 1</a></li>
                                        </ul>
                                        <h5 class="card-title font-weight-bold"><a href="<?php echo FULL_ROOT; ?>/blog/post/<?php echo $post['id']; ?>"><?php echo $post['title']; ?></a></h5>
                                    </div>
                                    <div class="card-header bg-white">
                                        <p><?php echo $post['description']; ?></p>
                                        <div class="clearflix">
                                            <ul class="list-inline mb-0">
                                                <li class="list-inline-item"><i class="far fa-clock"></i> <?php echo helper_format_date($post['published']); ?></li>
                                                <li class="list-inline-item"><i class="fas fa-user"></i> By Admin</li>
                                            </ul>
                                        </div>
                                    </div>
                                </div>
                            </div>

                            <?php endforeach; ?>

Here is my controller code:

    public function index()
    {
        $data = $this->blog->getPosts();
        $this->view('blog/index', $data);
    }

Here is my model code:

    public function getPosts()
    {
        $results = $this->db->select('msi_posts','status = 1');
        return $results;
    }

Here is the DB when only 1 post is active:

Thanks and if you are on holiday still you do not have to answer!

[sonicsleuth]

The function you refer to as "buggy" is not. It is designed to return an associative array if more than one record is found and a sequential array for a single record because it is used for both multiple and single queries, this is typical.

In your getPosts() method, you should check the value-type of the first element found in the returned records. If the value is an array return the results as is. If it is NOT an array, array_push() the results into a new array (making it become an associative array of one record) and return this new array. Then your foreach loop will work fine.

Read up on is_array() here http://php.net/manual/en/function.is-array.php

[jackttcoms]

i'm really sorry but i don't fully understand what you mean.

Do you mean something like this?

function is_assoc($test) {
        if (empty($test)) { return(false); }
        if (!is_array($test)) { return(false); }
        return ($test !== array_values($test));
}

or

if ( (array) $unknown !== $unknown ) {
    echo '$unknown is not an array';
} else {
    echo '$unknown is an array';
} 

or

foreach($something as $value){
    if(!in_array($value, $liste, true)){
        array_push($liste, $value);
    }
}

Thanks in advance!

---

AND REGARDS TO PREVIOUS ISSUE...

That's great thanks so much and i know this is only minor but is it possible to remove the gaps in between?

Also i have one final major question and its regarding MVC's in general! As i'm relatively new to them i'm wondering how i get data constantly from the database or how would i do it because basically in my db i have a table called 'settings' and it has 'title || Brand Name' in it so how would i get that title echoed on every page?

Do i do a helper or how do i get the entire settings database on hand ready for whenever i need it?

In my old code i used to do it like this - <title><?php echo $settings['title']; ?> - MVC Framework</title>

Thanks again

-- Also here is a gif of what i have made so far using your brilliant framework :) https://gyazo.com/c24c527f1529a834c96e1ff682d20225

[sonicsleuth]

To remove the empty line after each stylesheet line experiment with the trailing string that forces a return after each line. The "\r\n" is code for "return" and "newline". Try removing just the escaped \n and keep the \r. The two are used b/c of page encoding - if one failed the other would work. In your case, it seems both are being applied - one too many returns.

function load_style($paths)
{
    foreach ($paths as $path) {
        echo '<link rel="stylesheet" href="' . WEB_ROOT . 'css/' . $path . '.css" type="text/css" />' . "\r\n";
    }
}

To check if you have an associative array - Use this technique in your Controller to test the record results you get back from your Model query.

if(!is_array($results[0])) {
            // One Record.
            $new_results = array();
            array_push($new_results, $results);
            print_r($new_results);
        } else {
            // Multiple Records.
            return $results;
        }

If one record is returned, it will change the results from:

Array (
   [id] => 1
   ...
) 

into this...

Array(
   [0] => Array (
                  [id] => 1
                  ...
               ) 
)

and then your foreach will work fine.

[sonicsleuth]

As for having access to "settings" each time the page loads, making a "Helper" function is one way to go. Just have the Helper Settings function you make contain anything you comonly need.

Another approach, if the common values are gathered after login, would be to store those values in a session after login. Then you avoid the DB lookup on every page.

If you are referencing "static" data, like the name of your product for use in an HTML