Maximum name length seems to be one character too long

sonik-br / GDMENUCardManager

Manage content on SD Card for Dreamcast's GDMenu

GNU General Public License v3.0

226 stars 18 forks source link

Maximum name length seems to be one character too long #13

Closed ticky closed 3 years ago

ticky commented 3 years ago

I've set up a card using GDMenuCardManager, and once I put it on the GDEMU, the names are cut off for some of the things on it:

"Neon Genesis Evangelion Typing Project E" is cut off to "Neon Genesis Evangelion Typing Project "
"Official Sega Dreamcast Magazine 1999/11" is cut off to "Official Sega Dreamcast Magazine 1999/1"

I'm guessing this means that the maximum length of 40 characters is, in GDMenu's case, inclusive of the null terminator byte, because it seems like C#'s Substring method (used here) does what you'd expect.

sonik-br commented 3 years ago

I will take a look. But might take some time to test as I don't have access to my DC right now. The app limits the char count and during my testings it was fine. But I might have missed this detail. I don't know if the char textures in gdmenu have fixed width. If not, then this might be the problem.

ticky commented 3 years ago

Yep, both of these names were adapted to fit within the program's 40-character limit, but on the Dreamcast it's cut off.

Is there documentation somewhere of the GDMENU list format, or is it all based on what you've observed?

sonik-br commented 3 years ago

By observation. Trial and error. There's no documentation on GDMENU.