search

sonik-br / GDMENUCardManager

Manage content on SD Card for Dreamcast's GDMenu
GNU General Public License v3.0
226 stars 18 forks source link

Improve name handling #14

Closed ticky closed 3 years ago

ticky commented 3 years ago

This updates the name handling in two ways;

  1. It updates the maximum length to 39 as discussed in #13; I've tested this repeatedly and it's consistently the true limit
  2. Names are no longer transformed to uppercase, as GDMenu can handle mixed case titles just fine

Fixes #13

sonik-br commented 3 years ago

Thanks for the PR! I can't test it right now as I don't have access to my dreamcast at the moment. I do remember some users asking me to force the upercase but can't remember why. I think it was hard to read on a crt tv but might be wrong. Can you test it?

ticky commented 3 years ago

I don't have a CRT to test with, but it seems strange to me to restrict this for a subset of users when they could just use the caps lock key 😜

I'd suggest a compromise of making this a user-configurable setting, but I don't have enough experience with .NET core stuff to get far in that myself, I'm afraid

sonik-br commented 3 years ago

I will merge the PR later today. Your changes are working perfectly. Also the texts are very readable in a CRT TV. Was testing it now and found another bug. Renaming the game in the list is not working (at least in the windows build).