search

sonikro / flutter-okta-sdk

Okta's SDK Implementation for Flutter
BSD 3-Clause "New" or "Revised" License
19 stars 34 forks source link

Null safety support #12

Closed chaitanya-bhagavan closed 3 years ago

chaitanya-bhagavan commented 3 years ago

Adding support for null safety.

sonikro commented 3 years ago

Hello @chaitanya-bhagavan, thanks for contributing. I'd like to understand a bit more on what are the benefits of making all properties nullable ? Isn't this the opposite of Kotlin's Null Safety ?

Maybe, for the BaseRequest making some (but not all) properties is fine, as Okta may not have all those fields as mandatory.

But for the Return times of the methods, I think they should not be Nullable, since we expect those methods to always return that specific type, or throw an Exception.

chaitanya-bhagavan commented 3 years ago

@sonikro I have made the changes, please check

chaitanya-bhagavan commented 3 years ago

@sonikro Can you please merge this ?