OAuthSignatureMethod_PLAINTEXT.build_signature_base_string() does not conform to expected interface.

[GoogleCodeExporter]

This bug report is for the Python OAuth module.

The build_signature_base_string() method of OAuthSignatureMethod_PLAINTEXT
does not match the interface described by the OAuthSignatureMethod base
class, returning a single string rather than a pair of strings.

This causes a ValueError exception in OAuthServer._check_signature() when a
request is invalid (see the "if not valid_sig:" block).  If
OAuthSignatureMethod_PLAINTEXT correctly implemented the interface, a more
informative OAuthError would be produced.

Original issue reported on code.google.com by james.he...@gmail.com on 9 Oct 2008 at 5:29

[GoogleCodeExporter]

Simple patch that fixes the problem.

It seems a bit weird that this method is left for individual signature methods 
to
implement given that the spec defines only a single base string calculation 
method.

Original comment by james.he...@gmail.com on 9 Oct 2008 at 5:38

Attachments:

• oauth-plaintext.patch

[GoogleCodeExporter]

Original comment by leah.culver on 9 Jan 2009 at 12:30

[GoogleCodeExporter]

Original comment by leah.culver on 14 Jan 2009 at 7:32

• Added labels: Lib-Python

[GoogleCodeExporter]

Thanks! I've updated the lib with your changes.

Original comment by leah.culver on 14 Jan 2009 at 10:35

• Changed state: Fixed