Spellcheck language preference

[fedelibre]

I guess that the spellcheck defaults to the system language.

What if a non-english user will use Commit to contribute to an English repository? This dotted red confusion appears :-)

May you add a language preference? Or detect the language and always accept English.

Thanks

[ghost]

@fedelibre

See https://github.com/sonnyp/Commit/pull/98#issuecomment-1743451087 for a potential solution

[fedelibre]

Ok, then the setting is available. I'm happy I can disable it.

Switching to English doesn't seem to work now. I'm on Fedora Silverblue and maybe I don't have the english spellcheck dictionary?

[fedelibre]

However, if I disable it and reopen Commit, the spellchecking is active again. My choice is not saved.

Can you make sure that the last choice is kept?

[ghost]

However, if I disable it and reopen Commit, the spellchecking is active again. My choice is not saved.

Can you make sure that the last choice is kept?

If you're asking for repository-based spellchecking language config, then that's blocked by #92 Otherwise, if you're asking for global disabling, then that's not currently an option, since the current implementation only changes the spellchecking options for the current SourceView

It might be possible to steal gnome-text-editor's approach, where there is a global setting in the hamburger menu (in fact, this same issue is reproducible in gnome-text-editor by using the context menu), but i don't have the time to fix this, so I'm leaving this here for reference

[sonnyp]

I don't think we need a control in the menu.

We can remember what the user did last time.

In the future we can save per repo with https://github.com/sonnyp/Commit/issues/92

[fedelibre]

Ok, I'll close this issue