sonnyp / Commit

Commit message editor
https://apps.gnome.org/Commit/
GNU General Public License v3.0
132 stars 25 forks source link

Feature request: Spellcheck #90

Closed nathansamson closed 1 year ago

nathansamson commented 1 year ago

Title says it all. Builtin spellcheck so you don't make typo's...

sonnyp commented 1 year ago

https://gitlab.gnome.org/GNOME/gtk/-/issues/3814

nathansamson commented 1 year ago

Could it be integrated with this?

https://blogs.gnome.org/chergert/2023/07/12/spellchecking-for-gtk-4/

sonnyp commented 1 year ago

yes https://gitlab.gnome.org/chergert/libspelling/#in-javascript

nathansamson commented 1 year ago

Let me rephrase my question :)

Are you aware of this new spelling library, and do you have plans to integrate it (or are willing to accept contributions that use it)

sonnyp commented 1 year ago

I'm aware of it and Commit should make use of it :+1: but I don't have time to work on it.

I'd be very happy to review/help if someone is willing to give it a try.

This is what needs to be done

  1. Add libspelling module to the Flatpak manifest
  2. Integrate it, make sure to use ESM to import it import Spelling from 'gi://Spelling';

https://gitlab.gnome.org/chergert/libspelling/-/tree/main#in-javascript