sonnyp / Junction

Application/browser chooser
https://flathub.org/apps/re.sonny.Junction
GNU General Public License v3.0
457 stars 28 forks source link

Make headerbar in welcome window flat #113

Closed gregorni closed 1 year ago

gregorni commented 1 year ago

Just an idea, but I thought since the window is quite empty anyways, it might look good to have the headerbar flat.

sonnyp commented 1 year ago

I guess if the window isn't supposed to be dragged, it works too.

No strong opinion here, @tbernard wdyt?

gregorni commented 1 year ago

In GNOME; the header bar should only be flat if the rest of the window can be used to drag it.

Otherwise I could also cover the window in a Gtk.WindowHandle, which would make it draggeable (if that's a word). I think it wouldn't do any harm, since the window is, as I said, quite empty.

gregorni commented 1 year ago

Speaking of making the window draggeable anywhere, I think this could be done with the application chooser window as well.

sonnyp commented 1 year ago

@gregorni sounds good – can you update your PR to wrap both windows in WindowHandle ?

gregorni commented 1 year ago

I made #114 for that, but if you want both changes in this one PR, I can also merge my draggeable branch into flat-header.

gregorni commented 1 year ago

I made #114 for that, but if you want both changes in this one PR, I can also merge my draggeable branch into flat-header.

Alright, I just merged it, so this PR is now draggeable everywhere as well.

sonnyp commented 1 year ago

Related:

sonnyp commented 1 year ago

BTW, if you're interested – Junction needs a better welcome/onboarding experience.

We got this feedback in app reviews

Really wish you could set it as the default for images and videos with a click of a button like you can with browsers, though.