sonnyp / Junction

Application/browser chooser
https://flathub.org/apps/re.sonny.Junction
GNU General Public License v3.0
458 stars 29 forks source link

Fix broken formatting in metainfo file #13

Closed AsciiWolf closed 2 years ago

AsciiWolf commented 2 years ago

The broken formatting causes AppStream metadata to be broken - missing screenshot etc.

sonnyp commented 2 years ago
flatpak run org.freedesktop.appstream-glib validate data/re.sonny.Junction.metainfo.xml

passes - I think something went wrong on flathub when processing the screenshot

AsciiWolf commented 2 years ago
      <description
      >This is the first release of Junction. We hope you like it.</description>

This does not look valid to me.

AsciiWolf commented 2 years ago

By the way, appstream-util validator finds some other issues:

$ appstream-util validate re.sonny.Junction.metainfo.xml
re.sonny.Junction.metainfo.xml: FAILED:
• style-invalid         : <image> has vertical padding [https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot.png]
• style-invalid         : <image> has horizontal padding [https://raw.githubusercontent.com/sonnyp/Junction/main/data/screenshot.png]
• style-invalid         : <ul> cannot start a description [(null)]
• style-invalid         : Not enough <p> tags for a good description [0/1]
Validation of files failed
AsciiWolf commented 2 years ago

Anyway, feel free to close this PR if you think that everything is correct.

sonnyp commented 2 years ago

Thanks but this isn't fixing anything. The XML is valid.

Confirmed by previewing current version in GNOME Software.

I guess the flathub screenshot will be fixed on next release.

sonnyp commented 2 years ago

https://discourse.flathub.org/t/missing-screenshots/1852