sonnyp / Junction

Application/browser chooser
https://flathub.org/apps/re.sonny.Junction
GNU General Public License v3.0
457 stars 28 forks source link

Mangles spotify login link #143

Closed azizLIGHT closed 6 months ago

azizLIGHT commented 6 months ago

When using spotify flatpak and attempting to login the URL, junction captures the URL and asks which browser to open it in. I chose firefox and then I see spotify's website say response_type parameter is missing If I take the URL in the bottom and manually open it in firefox, spotify's login page loads just fine Another person had the same issue here

The URL passed from Spotify to Junction seen in the bottom is like:

https://accounts.spotify.com/login?continue=https%3A%2F%2Faccounts.spotify.com%2Foauth2%2Fv2%2Fauth%3Fclient_id%3DREDACTED%26response_type%3Dcode%26redirect_uri%3Dhttp%253A%252F%252F127.0.0.1%253A4381%252Flogin%26scope%3Dapp-remote-control%252Cplaylist-modify%252Cplaylist-modify-private%252Cplaylist-modify-public%252Cplaylist-read%252Cplaylist-read-collaborative%252Cplaylist-read-private%252Cstreaming%252Cugc-image-upload%252Cuser-follow-modify%252Cuser-follow-read%252Cuser-library-modify%252Cuser-library-read%252Cuser-modify%252Cuser-modify-playback-state%252Cuser-modify-private%252Cuser-personalized%252Cuser-read-birthdate%252Cuser-read-currently-playing%252Cuser-read-email%252Cuser-read-play-history%252Cuser-read-playback-position%252Cuser-read-playback-state%252Cuser-read-private%252Cuser-read-recently-played%252Cuser-top-read%26code_challenge%3DREDACTED-IT_HAS-DASHES_and_UNDERSCORES%26code_challenge_method%3DREDACTED&method=login-accounts&flow_ctx=REDACTED%3AREDACTED&utm_source=spotify&utm_medium=desktop-linux&utm_campaign=organic

Whatever that gets passed to firefox is broken If I paste that url directly into firefox bypassing junction it loads fine in firefox If I use Junction to send it to firefox, something goes wrong

sonnyp commented 6 months ago

Fixes by https://github.com/sonnyp/Junction/pull/142