sonnyp / Junction

Application/browser chooser
https://flathub.org/apps/re.sonny.Junction
GNU General Public License v3.0
458 stars 29 forks source link

Browser name label option #18

Closed LordShedy closed 2 years ago

LordShedy commented 2 years ago

Hi,

this app is such a beautiful extension to the system, loving it!

I am using several desktop files for differently configured firefox instances. When using Junction I cannot differentiate among the Firefox icons because I am not using different icons for the desktop files. I think it would be neat to have an option to enable some sort of label (for example Name from the desktop file).

Screenshot from 2021-10-25 19-38-57 Screenshot-20211025194014-1920x1080

sonnyp commented 2 years ago

Thank you for the kind words.

Yes - I wasn't sure how to display labels but I guess following GNOME Shell here would work well.

I'd probably put it behind a setting as to not clutter if it's not required.

I also thought of displaying labels only if there are multiple options with the same icon.Would that work for you? Would you want to see the label for all options or only for the ones with the same icon?

Until then you can use the tooltip - over the application with your mouse and the name should appear.

sonnyp commented 2 years ago

Also - a bit off topic but could you share what your OS, version and GTK Icon theme is ? I'm curious why you have a broken image in the welcome window.

LordShedy commented 2 years ago

I'd probably put it behind a setting as to not clutter if it's not required.

I think putting it as opt-in in the settings would be the best.

I also thought of displaying labels only if there are multiple options with the same icon.Would that work for you? Would you want to see the label for all options or only for the ones with the same icon?

My “OCD” tells me either all with labels or none 😄 but I would not mind label just for the duplicates.

Until then you can use the tooltip - over the application with your mouse and the name should appear.

Thanks for the tip!

Also - a bit off topic but could you share what your OS, version and GTK Icon theme is ? I'm curious why you have a broken image in the welcome window.

I am using:

sonnyp commented 2 years ago

Would you like to give this a try?

Should be fairly easy and a nice introduction to contributing to Junction and GNOME dev if you're interested.

The function is AppButton https://github.com/sonnyp/Junction/blob/23031ba4cbe0a1f85562cf9de8be472908957dbb/src/AppButton.js#L6

You'll want to move the GtkButton inside a GtkBox and add a GtkLabel in the box as well.

We don't have settings yet but if you can display beautiful labels that'd be the first step and of great help already.

References

sonnyp commented 2 years ago

I'm afraid it's not gonna help too much with this use case.

If your profiles are named Chromium Work - Chromium School - ... you still won't be able to differentiate because there isn't enough space for the text

Screenshot from 2021-10-28 21-01-04

What about a vertical layout like this

Screenshot from 2021-10-28 21-03-54

Finally a last option would be to try and implement something like this

If 2 apps have the same icon - remove the first common characters - soFirefox Work and Firefox School become Work and School

wdyt?

sonnyp commented 2 years ago

I'm happy to put labels as a setting but I'm starting to believe your use case would be better covered by an external app that can set custom icons. You can give https://flathub.org/apps/details/com.github.donadigo.appeditor a go.

The vertical layout is nice for mobile though so I'll keep that in mind.

LordShedy commented 2 years ago

Would you like to give this a try?

Should be fairly easy and a nice introduction to contributing to Junction and GNOME dev if you're interested.

The function is AppButton

https://github.com/sonnyp/Junction/blob/23031ba4cbe0a1f85562cf9de8be472908957dbb/src/AppButton.js#L6

You'll want to move the GtkButton inside a GtkBox and add a GtkLabel in the box as well.

We don't have settings yet but if you can display beautiful labels that'd be the first step and of great help already.

I am not a very proficient at building apps so I'd rather avoid that, although I would like to contribute somehow.

What about a vertical layout like this

I am unsure about the horizontal layout, it looks weird.

If 2 apps have the same icon - remove the first common characters - soFirefox Work and Firefox School become Work and School

Love this idea, I think that would be neat.

I'm happy to put labels as a setting but I'm starting to believe your use case would be better covered by an external app that can set custom icons. You can give https://flathub.org/apps/details/com.github.donadigo.appeditor a go.

Thanks, will try that.

LordShedy commented 2 years ago

The AppEditor app kinda fixed it for me but I am still in favor of this being implemented, it could be neat for people who do not want to have multiple icons of the same app and or for the people with firefox profiles.

Screenshot-20211028212943-1919x1045

sonnyp commented 2 years ago

Nice

Agree - your suggestion is still useful and I will put it behind a setting for a future version.

But the recommended way will be to set custom app icons / (short) names.

rafaelmardojai commented 2 years ago

If your profiles are named Chromium Work - Chromium School - ... you still won't be able to differentiate because there isn't enough space for the text

Probably not ideal, but what about ellipsize in the middle?

sonnyp commented 2 years ago

It looks / feels strange.

Screenshot from 2021-11-10 00-23-42

sonnyp commented 2 years ago

GNOME Shell application switcher suffers from the same problem

image

If someone is motivated they can try to achieve something similar to what the GNOME Shell app grid does.

sonnyp commented 2 years ago

Fixed in 1.2.0

Zzombiee2361 commented 2 years ago

Can't you just make the text multi line? Although doing that probably will make the text harder to ellipsis