sonnyp / Junction

Application/browser chooser
https://flathub.org/apps/re.sonny.Junction
GNU General Public License v3.0
457 stars 29 forks source link

Support for application actions #76

Closed jle64 closed 2 years ago

jle64 commented 2 years ago

It would be nice if support for application actions (aka jumplists) could be added, so that if a desktop entry defines additional actions we could use them to open files/links.

For example this would allow to open stuff in a browser private window or new window.

sonnyp commented 2 years ago

It's already supported - for now the UI is right click on the app icon

See https://github.com/sonnyp/Junction/pull/46

jle64 commented 2 years ago

Oooh nice, sorry for the noise then, I should have checked.

It doesn't seem to work on my system though, nothing happens on right click despite actions existing in the desktop file.

This is with the flatpak from flathub on fedora 36 with wayland.

sonnyp commented 2 years ago

It doesn't seem to work on my system though, nothing happens on right click despite actions existing in the desktop file.

For which app? What does the desktop file look like ?

jle64 commented 2 years ago

Looking at the desktop files I found the issue. The problem is not with junction its with the desktop files of some app not including "%u" in their action lines, hence while they didn't show up and I assumed it was not supported. When I edit them to add %u on the line they show up in junction and it works.

Anyway sorry and thanks for your time (and for junction).

sonnyp commented 2 years ago

Out of curiosity – can you share the apps ?

jle64 commented 2 years ago

Well there was only "ungoogled chromium" which misses %u upstream at least in the flathub flatpak, the other one was firefox but it was only an issue due to my own changes to the file :)

sonnyp commented 2 years ago

Thanks

Epihany was mising it as well - I fixed it in https://gitlab.gnome.org/GNOME/epiphany/-/merge_requests/1049

For "ungoogled chromium" - could you fix or report the problem upstream?

jle64 commented 2 years ago

I opened an issue here, hopefully this is the right place.

jle64 commented 2 years ago

And they fixed it.

sonnyp commented 2 years ago

Thanks for helping everyone \o/