Function does not take positional arguments

[yochananmarqos]

Building fails with Meson 0.60.0:

https://mesonbuild.com/Release-notes-for-0-60-0.html#the-python-modules-dependency-method-no-longer-accepts-positional-arguments

meson-log.txt:

Build started at 2021-10-25T14:53:12.564091
Main binary: /usr/bin/python
Build Options: -Db_lto=true -Db_pie=true -Dprefix=/usr -Dlibexecdir=lib -Dsbindir=bin -Dauto_features=enabled -Dbuildtype=plain -Dwrap_mode=nodownload
Python system: Linux
The Meson build system
Version: 0.60.0
Source dir: /build/tangram/src/tangram
Build dir: /build/tangram/src/build
Build type: native build
Project name: Tangram
Project version: 1.3.1
Build machine cpu family: x86_64
Build machine cpu: x86_64
Host machine cpu family: x86_64
Host machine cpu: x86_64
Target machine cpu family: x86_64
Target machine cpu: x86_64

tangram/data/appdata/meson.build:3:5: ERROR: Function does not take positional arguments.

[sonnyp]

https://mesonbuild.com/Release-notes-for-0-60-0.html#the-python-modules-dependency-method-no-longer-accepts-positional-arguments

[sonnyp]

@yochananmarqos I imagine you need a hotfix for Arch Linux ?

[yochananmarqos]

Your users would appreciate that, indeed. 😁

[sonnyp]

Could you try the tip of this branch https://github.com/sonnyp/Tangram/tree/v1.13 ?

I will release as 1.3.2 if you can build successfully.

[yochananmarqos]

Yes, it builds.

[sonnyp]

Thanks - v1.3.2 is out

Please also update pkgdesc to Browser for your pinned tabs and add gtk3 to dependencies.

Also and BTW - you don't need npm/rollup and so on - you can make the PKGBUILD simpler with

# Maintainer: Mark Wagie <mark dot wagie at tutanota dot com>
# Contributor: Sonny Piers <sonny at fastmail dot net>
pkgname=tangram
pkgver=1.3.2
pkgrel=1
pkgdesc="Browser for your pinned tabs"
arch=('any')
url="https://apps.gnome.org/app/re.sonny.Tangram"
license=('GPL3')
depends=('gjs' 'gtk3' 'libsoup' 'webkit2gtk')
conflicts=('gigagram' "$pkgname-web")
replaces=("$pkgname-web")
makedepends=('git' 'meson')
#checkdepends=('appstream-glib')
source=("${pkgname%-web}::git+https://github.com/sonnyp/Tangram.git#tag=v$pkgver")
sha256sums=('SKIP')

build() {
  arch-meson "$pkgname" build
  meson compile -C build
}

check() {

  # Validate appstream file fails, only validate desktop & schema files
  meson test 'Validate desktop file' 'Validate schema file' -C build --print-errorlogs
}

package(){
  DESTDIR="$pkgdir" meson install -C build

# Conflicts with tangram-bin binary
#  ln -s /usr/bin/re.sonny.Tangram "$pkgdir/usr/bin/$pkgname"
}

[yochananmarqos]

Thanks. However, the About dialog still says 1.3.1.

[sonnyp]

Nice catch - forgot to update the version number -_-

It's fixed in tag v1.3.2

[acidhorse1972]

Meson sux. Back to Make.