Bug: missing favicons - Githubissues

sonnyp / Tangram

Browser for your pinned tabs

https://apps.gnome.org/app/re.sonny.Tangram/

GNU General Public License v3.0

882 stars 37 forks source link

Bug: missing favicons #238

Open erlefloch opened 1 year ago

erlefloch commented 1 year ago

It would be great to be able to choose the tab icon manually. This would be useful for example for Slack, which doesn't display any icon near the tab title:

victorodg commented 1 year ago

Cool, I've been missing that too. I'm gonna try to do it. Never contributed to a github repo ever. It'll be my first one

sonnyp commented 1 year ago

I don't want custom tab icons for now.

Let's solve the problem of Tangram not picking up Slack favicon instead.

sonnyp commented 1 year ago

To clarify: tabs are taking too much space, I might remove them soon in favor of https://floss.social/@sonny/109672793649336496

until then it's best not to look into this

victorodg commented 1 year ago

Oh but I really like the spacing for the tabs :( could we make it customizable?

sonnyp commented 1 year ago

Why not :+1:

victorodg commented 1 year ago

Here I have GitHub not displaying the icon too. Kinda bugs me. Could I do something about it?

sonnyp commented 1 year ago

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web https://github.com/sonnyp/Tangram/blob/f06d83a89520f6aed8bf4fc7a0ed81de6108d254/src/tab.js#L27

victorodg commented 1 year ago

You'll have to find out where it's failing - it's probably a small thing since it works fine in Epiphany / GNOME Web

https://github.com/sonnyp/Tangram/blob/f06d83a89520f6aed8bf4fc7a0ed81de6108d254/src/tab.js#L27

Cool, I'll try

erlefloch commented 1 year ago

@sonnyp & @victorodg thank you very much ! I've updated the title of the issue to match the discussion.

erlefloch commented 1 year ago

Epiphany / GNOME web on browser tab:

github favicon ✗
slack favicon ✓

Epiphany / GNOME web on PWA:

github favicon ✓
slack favicon ✗

🙃

sonnyp commented 1 year ago

you have to use GNOME Web 44, not 43

erlefloch commented 1 year ago

Thanks for the hint. Using Epiphany Technology Preview (flatpak, version 44~rc) :

browser tab:

github favicon still ✗
slack favicon still ✓

PWA:

PWA installation did not work on Epiphany Technology Preview (tried a few times).

EDIT: tried again with Epiphany v45. The Slack favicon is now correctly displayed both on browser tab and webapp, whereas the GitHub favicon fails both.