search

sonnyp / troll

Libraries for GNOME JavaScript (GJS)
ISC License
45 stars 7 forks source link

Proper package.json, to make npm install work #6

Closed ranfdev closed 2 years ago

ranfdev commented 2 years ago

I tried running npm install https://github.com/sonnyp/troll.git but I get npm ERR! Cannot read properties of undefined (reading 'spec')

I think that's because the file package.json is missing many fields.

Could you run npm init in the repo to set the missing metadata?

sonnyp commented 2 years ago

I use troll as a git submodule – is that an option for you?

ranfdev commented 2 years ago

I use troll as a git submodule – is that an option for you?

Yes, git submodules work, I just think having a real package keeps everything more organized.

sonnyp commented 2 years ago

Fixed by https://github.com/sonnyp/troll/pull/9