Project 3: Twitter Clone Completed First Review

[sonnytron]

This is my submitted completed project @codepathreview @codepath
I didn't clean up the UI. I focused on hitting the required user stories and adding optional stories. It's very "engineered". I also had an issue with the UI. In GenyMOtion, my UI appeared correct with margin/padding on my dialog fragment. But for some reason my device has very low/no margins on the dialog fragment. I didn't have time to diagnose.

[codepathreview]

Decent submission, consider adding more challenging optional stories. A few notes after checking out the code:

• Good to see you were able to format the timestamp cleanly
• Good to see you refreshed the timeline after composing a new tweet
• Nice touch with the character count being displayed while the user composes a tweet
• Nice to see you used a SwipeRefreshLayout library for easy timeline refreshes
• Consider adding progress bars to your app whenever a network request goes out
• Consider adding ActiveAndroid to the Tweet and User. See the persistence guide and this other guide for more details.
• Consider better organizing your source files

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.