sonofagl1tch / AWSDetonationLab

This script is used to generate some basic detections of the aws security services
Apache License 2.0
71 stars 12 forks source link

automate the removal of s3 buckets #84

Open sonofagl1tch opened 5 years ago

sonofagl1tch commented 5 years ago

after cloudformation template is delete, the s3 buckets are kept if they have objects within them. We need to either add an option to choose buckets are deleted fully with a lambda function or some other solution.

ideas

mgmacias95 commented 5 years ago

In addition to that, we should remove the DeletionPolicy field since now it isn't removing any bucket, regardless of the data it contains: https://github.com/sonofagl1tch/AWSDetonationLab/blob/8d92a326bb0a4875d7e93764d8ff9dd75a7d5a24/awsDetonationLab.template#L1480-L1484