search

sonoftunk / Shipwright

1 stars 0 forks source link

Check Tracker shows wrong dungeon label (possibly entrance rando related) #30

Closed sonoftunk closed 1 year ago

sonoftunk commented 1 year ago

As shown here, RR#4822 on discord notes that in the experimental branch that does include entrance rando, the label is listed as Vanilla but the checks show as MQ. The dungeon is MQ. image

sonoftunk commented 1 year ago

This should not be possible, as the code that decides what the label should be is the same code that decides what checks to shoq image

sonoftunk commented 1 year ago

Determined that the issue is related to the order of the checks. If the first check that would show in an area is not the dungeon proper (boss, colossus' hands, etc), it will show as Vanilla when it should show as MQ, because the SceneID of the area isn't the MQ Dungeon. Unsure of fix.

sonoftunk commented 1 year ago

Fixed by 25f89fdc15dc65e87adf3aefedeb429b97b29be1